[LU-9289] Fix fileset string length issue

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.9.0
• Labels: nodemap
• Severity: 3
• Assignee: Emoly Liu
• Reporter: Sebastien Buisson (Inactive)

Description

Patch http://review.whamcloud.com/21857 added this code in nodemap_fileset_seq_write():

	OBD_ALLOC(nm_fileset, count);
	if (nm_fileset == NULL)
		RETURN(-ENOMEM);

	if (copy_from_user(nm_fileset, buffer, count))
		GOTO(out, rc = -EFAULT);

'count' is the length of the string to write. So it is necessary to allocate count+1 for nm_fileset in order to add a '\0' after copy_from_user().

Comments

[Peter Jones]

Landed for 2.10

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/26335/
Subject: LU-9289 nodemap: fix fileset string length issue
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7a32eff39c8b4bd17f173a62293374c5b4ff04e1

[Peter Jones]

Emoly

Could you please review this patch?

Thanks

Peter

[Gerrit Updater]

Sebastien Buisson ([e-mail]) uploaded a new patch: https://review.whamcloud.com/26335
Subject: LU-9289 nodemap: fix fileset string length issue
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 73071dde8c826897bc106a418821417f770dac99