[LU-929] add configure --with-ldiskfsprogs to e2fsprogs

• Type: Improvement
• Resolution: Done
• Priority: Minor
• Affects Version/s: Lustre 2.1.0
• Labels: e2fsprogs llnl

Epic

e2fsprogs

• Assignee: Jian Yu
• Reporter: Ramiro Alba Queipo (Inactive)

Description

This is an adaptation of the patches for bug:

https://bugzilla.lustre.org/show_bug.cgi?id=22983

Enables a new configure option (--with-ldiskfsprogs) which combined with the same option in lustre, allows e2fsprogs essential commands to be installed without conflicting e2fsprogs package on distribution

Issue Links

• is duplicated by: LU-4032 Resolve confusion over custom e2fsprogs

Comments

[Christopher Morrone (Inactive)]

It would be a good idea to make those changes yes. I've been porting forward the patches for quite some time, but not actively seeking out new changes that could use those substitutions.

[Jian Yu]

Hello Chris,

Thanks for the patches.

I just reviewed http://review.whamcloud.com/3204. Besides some build issues, I found there were still plenty of "e2fsck", "debugfs", etc. commands which were not substituted with "@FSCKPROG@", "@DEBUGFSPROG@", etc. in many files (like *.8.in and *.spec.in files). I'm wondering whether we need make all of these changes in those files. Do you have any thoughts on this?

[Christopher Morrone (Inactive)]

Updated patches for master-lustre, now that Whamcloud has dropped the use of quilt.

http://review.whamcloud.com/3204
http://review.whamcloud.com/3205

[Peter Jones]

YuJian

Could you please assess these patches?

Thanks

Peter

[Christopher Morrone (Inactive)]

I rebased our two main ldiskfsprogs patches onto WC's latest and submitted them:

http://review.whamcloud.com/2582
http://review.whamcloud.com/2583

[Christopher Morrone (Inactive)]

I am willing to do a push, but I will not have time to iterate on it at the moment.

It certainly would be nice to stop carrying it ourselves.

The notable problem would be that the patch doesn't completely convert the support libraries to ldiskfs naming and package those libraries. If one attempts a dynamic build of ldiskfsprogs, the binaries will wind up linking dynamically with e2fsprog's helper library and break in strange ways.

So, yes, I'll post if that is helpful.

Our changes are public here if you want a preview:

https://github.com/chaos/ldiskfsprogs

[Peter Jones]

Chris

Is this something that LLNL would like to push upstream? If so, could you please upload the changes into gerrit with the appropriate signoff?

Thanks

Peter

[Andreas Dilger]

Hi Ramiro,
sorry for the delay in responding to your contribution. Firstly, thank you for taking the time to contribute these changes.

Patches for e2fsprogs should be submitted via Gerrit for testing and inspection. Please see the wiki pages:

http://wiki.whamcloud.com/display/PUB/Submitting+Changes
http://wiki.whamcloud.com/display/PUB/Using+Gerrit

e2fsprogs changes are tracked using the tools/e2fsprogs git repository.