[LU-9430] logic errors in lgss_sk code

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Lustre 2.9.0
• Fix Version/s: Lustre 2.10.0
• Severity: 4
• Assignee: Chris Hanna
• Reporter: Chris Hanna

Description

Aside from the encryption protocol problems affecting the shared key feature in LU-9073, there are a couple trivial bugs in sk_name2hmac(). These affect logic for setting the hash type when creating a shared key. For example, the encryption type is echoed to stdout rather than being properly assigned. I will submit a patch to fix this.

Example:
$ ./lgss_sk -w testlu.key -f lustretest -d /dev/urandom -i SHA512 -t server
sha512Reading random data for shared key from '/dev/urandom'
$ ./lgss_sk -r testlu.key
Version: 1
Type: server
HMAC alg: crypt
Crypto alg: sha256
Ctx Expiration: 604800 seconds
Shared keylen: 256 bits
Prime length: 2048 bits
File system: lustretest
MGS NIDs:
Nodemap name: default
Shared key:
0000: a685 0f19 c96a 625e 9cd7 d800 26f2 228b .....jb^....&.".
0010: 86b8 a0e0 34a4 2fae 0b45 5d46 450a 5285 ....4./..E]FE.R.

Issue Links

• is related to: LU-9073 SSK: lgss_sk generates keys with invalid HMAC and Crypto algorithms
• is related to: LU-8602 Support GSS crypto code with linux 4.6 kernels