Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9619

automatically add Test-Parameters: line for simple patches

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • 9223372036854775807

    Description

      It would be possible to have the contrib/git-hooks/prepare-commit-message script automatically add a Test-Parameters: trivial tag (with an optional testlist=<test> item) to patches that are only modifying test scripts. As with the Signed-off-by: line, this should be added in a commented-out form so that it is up to the developer to determine if this is appropriate, but having the line present would at least remind the user about this option to reduce testing time.

      Attachments

        Activity

          [LU-9619] automatically add Test-Parameters: line for simple patches

          colmstea, nice!

          adilger Andreas Dilger added a comment - colmstea , nice!
          colmstea Charlie Olmstead made changes -
          Link New: This issue is related to ATM-3284 [ ATM-3284 ]

          As of June 9th, 2025, AT forces trivial on patches that only modify test suite files (ATM-3284)

          Here is a recent example: https://review.whamcloud.com/#/c/ex/lustre-release/+/59881/

          "NOTE: This patch has been classified as trivial due to the minimal changes"

          colmstea Charlie Olmstead added a comment - As of June 9th, 2025, AT forces trivial on patches that only modify test suite files (ATM-3284) Here is a recent example: https://review.whamcloud.com/#/c/ex/lustre-release/+/59881/ "NOTE: This patch has been classified as trivial due to the minimal changes"
          adilger Andreas Dilger made changes -
          Link New: This issue is related to ATM-3669 [ ATM-3669 ]
          adilger Andreas Dilger made changes -
          Assignee Original: Tim Day [ timday ] New: WC Triage [ wc-triage ]

          To a limited extent, we now have this with the "review-subtest-change" sessions, that automatically run extra iterations of new/modified test sessions in the test scripts.

          As yet, there is no mapping from code changes to test scripts, so patches without extra test scripts will not trigger additional testing.

          adilger Andreas Dilger added a comment - To a limited extent, we now have this with the "review-subtest-change" sessions, that automatically run extra iterations of new/modified test sessions in the test scripts. As yet, there is no mapping from code changes to test scripts, so patches without extra test scripts will not trigger additional testing.

          "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52420
          Subject: LU-9619 contrib: rewrite prepare-commit-msg in python
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 4fd637ebe2f6fed1ac3da8fc5ee044cd61f271ee

          gerrit Gerrit Updater added a comment - "Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52420 Subject: LU-9619 contrib: rewrite prepare-commit-msg in python Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 4fd637ebe2f6fed1ac3da8fc5ee044cd61f271ee

          timday, are you planning to work on this any further? I think automating the generation of Test-Parameters: lines in the prepare-commit-message Git hook would optimize the use of testing resources, and simplify the submission of larger patch series (which in turn would make patch reviews easier to do). I've linked Oleg's script to do something similar for the Gerrit Janitor testing, but doing something similar for Test-Parameters: would also help Autotest.

          adilger Andreas Dilger added a comment - timday , are you planning to work on this any further? I think automating the generation of Test-Parameters: lines in the prepare-commit-message Git hook would optimize the use of testing resources, and simplify the submission of larger patch series (which in turn would make patch reviews easier to do). I've linked Oleg's script to do something similar for the Gerrit Janitor testing, but doing something similar for Test-Parameters: would also help Autotest.

          Oleg's code for determining tests to be run based on the patch content is in https://github.com/verygreen/lustretester/blob/master/gerrit_build-and-test-new.py

          adilger Andreas Dilger added a comment - Oleg's code for determining tests to be run based on the patch content is in https://github.com/verygreen/lustretester/blob/master/gerrit_build-and-test-new.py
          adilger Andreas Dilger made changes -
          Link New: This issue is related to ATM-2666 [ ATM-2666 ]

          People

            wc-triage WC Triage
            adilger Andreas Dilger
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated: