[LU-9832] minor()/major()/makedev() maro use problems with newer gcc

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

building Lustre tools on Fedora 26 I am getting this warning now:

mcreate.c:82:13: error: In the GNU C Library, "minor" is defined
 by <sys/sysmacros.h>. For historical compatibility, it is
 currently defined by <sys/types.h> as well, but we plan to
 remove this soon. To use "minor", include <sys/sysmacros.h>
 directly. If you did not intend to use a system-defined macro
 "minor", you should undefine it after including <sys/types.h>. [-Werror]
                         dev = makedev(strtoul(optarg, NULL, 0), minor(dev));
             ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                               mcreate.c:82:13: error: In the GNU C Library, "makedev" is defined
 by <sys/sysmacros.h>. For historical compatibility, it is
 currently defined by <sys/types.h> as well, but we plan to
 remove this soon. To use "makedev", include <sys/sysmacros.h>
 directly. If you did not intend to use a system-defined macro
 "makedev", you should undefine it after including <sys/types.h>. [-Werror]
                         dev = makedev(strtoul(optarg, NULL, 0), minor(dev));
             ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                               mcreate.c:85:13: error: In the GNU C Library, "major" is defined
 by <sys/sysmacros.h>. For historical compatibility, it is
 currently defined by <sys/types.h> as well, but we plan to
 remove this soon. To use "major", include <sys/sysmacros.h>
 directly. If you did not intend to use a system-defined macro
 "major", you should undefine it after including <sys/types.h>. [-Werror]
                         dev = makedev(major(dev), strtoul(optarg, NULL, 0));
             ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                               

Comments

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33161
Subject: LU-9832 tests: Use sys/sysmacros.h for major/minor/makedev
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 02b50a67351e54a7f4563f27363601c2d1cea341

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28360/
Subject: LU-9832 tests: Use sys/sysmacros.h for major/minor/makedev
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 650b7450b612943e7ade76434c3be70b06f58f58

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28360
Subject: LU-9832 tests: Use sys/sysmacros.h for major/minor/makedev
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fc59e7db2aa02874c64e27de02402a47592846b8