[LU-9834] misleading loop in llapi_layout_test.c test 29

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Labels: easy test
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

Smatch highlights:

        for (i = LOV_MAX_STRIPE_COUNT-1; i <= 0; i--) {
                rc = llapi_layout_ost_index_get(layout, i, &ost0);
                ASSERTF(rc == 0, "errno = %d", errno);
                ASSERTF(ost0 == nost, "ost=%"PRIu64", nost=%"PRIu64"",
                        ost0, nost);
                nost++;
                if (nost == num_osts)
                        nost = 0;
        }

Since LOV_MAX_STRIPE_COUNT-1 is always > 0 and the end condition is <= 0 - we never enter this loop.