[LU-9934] support gcc7

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0
• Affects Version/s: Lustre 2.11.0
• Environment: gcc7
• Assignee: Alex Zhuravlev
• Reporter: Alex Zhuravlev

Description

Lustre doesn't build with newer gcc7 due to many different warnings. some are easier to fix in the code. another are rather false (see an example below) and easier to supress.

util/parser.c:575:25: error: ‘%2d’ directive output may be truncated writing between 2 and 10 bytes into a region of size 4 [-Werror=format-truncation=]

Issue Links

• is related to: LU-9833 New gcc compiler generates a lot of format-truncation warnings
• is related to: LU-8587 gcc6 compatibility

Comments

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33160
Subject: LU-9934 build: address issues raised by gcc7
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 3b90539df347a9669bda22691855f98b4f7c06b1

[Gerrit Updater]

Li Dongyang ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31791
Subject: LU-9934 build: fix gcc7 complains in lprocfs_status_server.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ca080cc5877ed4bb521c03466f92324760d5ff9f

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28810/
Subject: LU-9934 build: support for gcc7
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4b67e5a8150309f4bbeb43a9095f12243be6dcfa

[James A Simmons]

Thanks. I also see another patch just landed that break Ubuntu17 builds again  Its in lnetconfig library.

[Alex Zhuravlev]

I've updated my patch (now much smaller) to be able to build with gcc7
notice #include <sys/sysmacros.h>
w/o that I'm getting this:

libmount_utils_ldiskfs.c: In function ‘tune_block_dev’:
libmount_utils_ldiskfs.c:1234:13: error: In the GNU C Library, "major" is defined
by <sys/sysmacros.h>. For historical compatibility, it is
currently defined by <sys/types.h> as well, but we plan to
remove this soon. To use "major", include <sys/sysmacros.h>
directly. If you did not intend to use a system-defined macro
"major", you should undefine it after including <sys/types.h>. [-Werror]
if (major(st.st_rdev) == LOOP_MAJOR)
^~~~~~~~~~~~~~~~~~~~~~~~~

[Alex Zhuravlev]

what's wrong with -Wno-format-truncation ?

[Alex Zhuravlev]

I'm still getting those errors with gcc7.. will it be another patch?

[Alex Zhuravlev]

going to check in my setup today.

[Peter Jones]

Alex

Does your patch need to land too or was James's sufficient?

Peter