Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9941

lsm_is_composite() isn't right

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.11.0, Lustre 2.10.2
    • Lustre 2.10.0
    • None
    • 3
    • 9223372036854775807

    Description

      static inline bool lsm_is_composite(__u32 magic)
{
        return !!(magic & LOV_MAGIC_COMP_V1);
}

      it's not right, magic contains LOV_MAGIC_MAGIC also will be regarded as composite magic.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. LU-9530 Interop 2.9<->master sanity test_184a: swap of file layout failed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-9528 Interop 2.9<->master sanity test_34h: New size wrong 10485760 != 1000

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Activity

            [LU-9941] lsm_is_composite() isn't right
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-9528 [ LU-9528 ]
            mdiep Minh Diep made changes -
            Labels Original: LTS
            gerrit Gerrit Updater added a comment -

            John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30342/
            Subject: LU-9941 lov: lsm_is_composite isn't right
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set:
            Commit: 6ec70b0e11d407156fa3057a8c15c293bc7b2480

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30342/ Subject: LU-9941 lov: lsm_is_composite isn't right Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: 6ec70b0e11d407156fa3057a8c15c293bc7b2480
            mdiep Minh Diep made changes -
            Fix Version/s New: Lustre 2.10.2 [ 13494 ]
            adilger Andreas Dilger made changes -
            Labels New: LTS
            adilger Andreas Dilger made changes -
            Description Original: static inline bool lsm_is_composite(__u32 magic)

            \{

                    return !!(magic & LOV_MAGIC_COMP_V1);

            }

             

            it's not right, magic contains LOV_MAGIC_MAGIC also will be regarded as composite magic.             		New: {code}
            static inline bool lsm_is_composite(__u32 magic)
            {
                    return !!(magic & LOV_MAGIC_COMP_V1);
            }
            {code}

            it's not right, magic contains {{LOV_MAGIC_MAGIC}} also will be regarded as composite magic.
            adilger Andreas Dilger made changes -
            Link New: This issue is duplicated by LU-9530 [ LU-9530 ]
            gerrit Gerrit Updater added a comment -

            Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/30342
            Subject: LU-9941 lov: lsm_is_composite isn't right
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: 481d278e9d6e205041c6afd3d9e9d2338d7acb7f

            gerrit Gerrit Updater added a comment - Jinshan Xiong (jinshan.xiong@intel.com) uploaded a new patch: https://review.whamcloud.com/30342 Subject: LU-9941 lov: lsm_is_composite isn't right Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 481d278e9d6e205041c6afd3d9e9d2338d7acb7f
            gerrit Gerrit Updater added a comment -

            Bobi Jam (bobijam@hotmail.com) uploaded a new patch: https://review.whamcloud.com/29128
            Subject: LU-9941 lov: lsm_is_composite isn't right
            Project: fs/lustre-release
            Branch: flr
            Current Patch Set: 1
            Commit: 6ac7455a072e21179703ab85a656ee60ca28ff8c

            gerrit Gerrit Updater added a comment - Bobi Jam (bobijam@hotmail.com) uploaded a new patch: https://review.whamcloud.com/29128 Subject: LU-9941 lov: lsm_is_composite isn't right Project: fs/lustre-release Branch: flr Current Patch Set: 1 Commit: 6ac7455a072e21179703ab85a656ee60ca28ff8c
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.11.0 [ 13091 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]

            People

              bobijam Zhenyu Xu
              bobijam Zhenyu Xu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: