[LU-10131] Update inode attributes on unlink

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0, Lustre 2.10.2
• Severity: 3
• Assignee: Patrick Farrell (Inactive)
• Reporter: Patrick Farrell (Inactive)

Description

Currently, the last unlink of an inode sends back the inode attributes from the MDS, but the client ignores them. This results in i_nlink on the inode (in memory on the client) staying at one after it has been fully unlinked, which means it stays in memory until discarded from pressure. This is also problematic for wrapfs atop Lustre, would like to use the nlink count to be certain the file is really gone.

The only attribute which is relevant on a fully unlinked inode is i_nlink, so we just read that out. Patch coming momentarily.

Issue Links

• is related to: LU-2857 2.1.4<->2.4.0 interop: sanity test_76: FAIL: inode slab grew from 11183 to 12183
• is related to: LU-7925 ll_d_iput() can clear i_nlink for an inode in use
• is related to: LU-2036 sanity.sh test_76: fails with lod/osp (inodes are not purged as expected)

Comments

[Patrick Farrell (Inactive)]

Yes, I know - Andrew and I hashed out the new patch together. FWIW, I don't think test 76 could pass with that approach to the i_nlink update, though I might be wrong.

[Andreas Dilger]

The patch http://review.whamcloud.com/19164 in LU-7925 was the one that removed the i_nlink update.

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/29785/
Subject: LU-10131 llite: Update i_nlink on unlink
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 00fea22a18bf1bec71869be2fc5c661ed5d99b4d

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/29785
Subject: LU-10131 llite: Update i_nlink on unlink
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: b819421c7873dee9b6c9e904776510d5c7896b12

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/29651/
Subject: LU-10131 llite: Update i_nlink on unlink
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 947b22b08d3725852a811a9e330562dd986d7336

[Gerrit Updater]

Patrick Farrell ([e-mail]) uploaded a new patch: https://review.whamcloud.com/29651
Subject: LU-10131 llite: Update i_nlink on unlink
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 14f7e4c59437b52222136382e12773aa5e353b33