Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10269

Fixes for selective trybits

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.11.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      While checking the waiting queue for inodebits lock it is needed to take into account also try_bits of new lock and locks in that queue.

      Another topic to solve in this ticket is the correct using of try_bits from callers and avoiding useless or trouble making cases with extra inodebits.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-11199 mdsrate open() performance degradation

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-10948 client cache open lock after N opens

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-10269] Fixes for selective trybits
            pjones Peter Jones added a comment -

            Landed for 2.11

            pjones Peter Jones added a comment - Landed for 2.11
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30343/
            Subject: LU-10269 ldlm: allow trybits in waiting queue
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 916bfe080520bdfb9a8d4e35ce7095c5b632f4eb

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30343/ Subject: LU-10269 ldlm: allow trybits in waiting queue Project: fs/lustre-release Branch: master Current Patch Set: Commit: 916bfe080520bdfb9a8d4e35ce7095c5b632f4eb
            green Oleg Drokin added a comment -

            I think another desired thing would be to more selectively drop bits from trylocks.

            For example if we see a granted lock that blocks us, OR a waiting lock that blocks up based on non-optional bits, reducing our bits (or bits of that waiting lock) is pointless - because we know we would conflict no matter what.

            green Oleg Drokin added a comment - I think another desired thing would be to more selectively drop bits from trylocks. For example if we see a granted lock that blocks us, OR a waiting lock that blocks up based on non-optional bits, reducing our bits (or bits of that waiting lock) is pointless - because we know we would conflict no matter what.
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30246/
            Subject: LU-10269 ldlm: fix the issues introduced by try bits
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 4f50273a3ed89bc00d5f36fc2606cc40680f450f

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30246/ Subject: LU-10269 ldlm: fix the issues introduced by try bits Project: fs/lustre-release Branch: master Current Patch Set: Commit: 4f50273a3ed89bc00d5f36fc2606cc40680f450f
            gerrit Gerrit Updater added a comment -

            Mike Pershin (mike.pershin@intel.com) uploaded a new patch: https://review.whamcloud.com/30343
            Subject: LU-10269 ldlm: allow trybits in waiting queue
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: d37cd567182a9302ecb81e2e58b92e6d1ea8e615

            gerrit Gerrit Updater added a comment - Mike Pershin (mike.pershin@intel.com) uploaded a new patch: https://review.whamcloud.com/30343 Subject: LU-10269 ldlm: allow trybits in waiting queue Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: d37cd567182a9302ecb81e2e58b92e6d1ea8e615
            gerrit Gerrit Updater added a comment -

            Mike Pershin (mike.pershin@intel.com) uploaded a new patch: https://review.whamcloud.com/30246
            Subject: LU-10269 ldlm: fix the issues introduced by try bits
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 12e263639a91458e52db5759fbf80bfc97dd15ac

            gerrit Gerrit Updater added a comment - Mike Pershin (mike.pershin@intel.com) uploaded a new patch: https://review.whamcloud.com/30246 Subject: LU-10269 ldlm: fix the issues introduced by try bits Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 12e263639a91458e52db5759fbf80bfc97dd15ac

            People

              tappro Mikhail Pershin
              tappro Mikhail Pershin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: