[LU-10560] Fixes for 4.14 kernel

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.12.0
• Labels: llnl
• Severity: 3
• Assignee: James A Simmons
• Reporter: Amir Shehata (Inactive)

Description

While Mike Marciniszyn was testing the TID-RDMA he tried to build Lustre against upstream. And ran into this build error:

make[3]: Entering directory `/nfs/sc/disks/fabric_work/mmarciniszyn/repos/wfr/wf                                                                                                                                                             r-linux-devel'
  CC [M]  /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-tracefile.o
  CC [M]  /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-debug.o
In file included from /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-debug.c:50:0:
./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to incomplete type
  current->thread.addr_limit = fs; 

Issue Links

• is related to: LU-11132 LC_BI_BDEV: configuration problem for 2.6 kernel
• is related to: LU-9558 Support linux kernel version 4.12
• is related to: LU-11310 support for SLES 15
• is related to: LU-10805 fixes for 4.15 kernel
• is related to: LU-10997 Ubuntu 18 support
• is related to: LU-10934 integrate statx() API with Lustre

Comments

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32268
Subject: LU-10560 llite: remove assigning f_version in ll_readir.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1de9c46e2dbb64cf788f40e52bf829b334b9da0c

[James A Simmons]

We have a patch for ldiskfs under this ticket so don't close.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31948/
Subject: LU-10560 libcfs: Fix inconsistent declaration for cfs_kernel_write()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f19699186d29ba8561d67b4457e98c018ea26317

[Peter Jones]

Ok. 4.15 work is happening under LU-10805 but it sounds like this last change should be enough to support 4.14 - thanks!

[Mike Marciniszyn (Inactive)]

I noted that that the error in the backport in https://review.whamcloud.com/#/c/31928 and that is probably due to the const discrepancy.

This is the only issue I have with 4.14.x kernel and it as it is working fine for our testing.

There are issues with 4.15.x, but i haven't gotten to those yet.   Some notables:

• timer API changes
• const nits

My objective here is to do some Lustre testing with our upstream work for OPA (lnet_selftest, lnet_ping)

[Peter Jones]

mmarcini is this now the last patch or are there still more to come?

[Gerrit Updater]

Mike Marciniszyn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31948
Subject: LU-10560 libcfs: Fix inconsistent const for cfg_kernel_write()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 874d454c7aeafb849862778dc6f163cc9c1938d7

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31928
Subject: LU-10560 libcfs: Use kernel_write when appropriate
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 94d96caa0986d6ff539d75496f3443f159f32313

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31927
Subject: LU-10560 libcfs: handle rename to wait_queue_entry_t
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 13e2315bf370f67845770a34c658a83ab26a9720

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31926
Subject: LU-10560 lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: e22e1cd2631e3c4a85577d001d5b0571fe8f77eb

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31925
Subject: LU-10560 llite: remove extra headers from rw26.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: ff9ab6a368ce3bf2187b047051b7eefc7a997ae0