Details

    • 3
    • 9223372036854775807

    Description

      2256 »·······/* grab pending txs while I have the lock */
      2257 »·······list_add(&txs, &peer_ni->ibp_tx_queue);
      2258 »·······list_del_init(&peer_ni->ibp_tx_queue);
      

      This code is erroneous. We should be moving all the transmits on peer_ni->ibp_tx_queue to the local txs variable then we afterward we iterate through them and send any pending txs.

      However currently these txs are simply dropped. We should be using list_splice()

      Attachments

        Activity

          [LU-10682] o2iblnd txs can be dropped silently

          John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31520/
          Subject: LU-10682 lnd: pending transmits dropped silently
          Project: fs/lustre-release
          Branch: b2_10
          Current Patch Set:
          Commit: cfe31e7b2dc68bad1175d313c05e1aaa4d519c86

          gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31520/ Subject: LU-10682 lnd: pending transmits dropped silently Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: cfe31e7b2dc68bad1175d313c05e1aaa4d519c86

          Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31520
          Subject: LU-10682 lnd: pending transmits dropped silently
          Project: fs/lustre-release
          Branch: b2_10
          Current Patch Set: 1
          Commit: 43fd133e6c38199eebb49c2a8c5f5b2febc81f9e

          gerrit Gerrit Updater added a comment - Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31520 Subject: LU-10682 lnd: pending transmits dropped silently Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 43fd133e6c38199eebb49c2a8c5f5b2febc81f9e
          pjones Peter Jones added a comment -

          Landed for 2.11

          pjones Peter Jones added a comment - Landed for 2.11

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31374/
          Subject: LU-10682 lnd: pending transmits dropped silently
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: f5c6228f0351787aefb76cb8f807eede3371ea2e

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31374/ Subject: LU-10682 lnd: pending transmits dropped silently Project: fs/lustre-release Branch: master Current Patch Set: Commit: f5c6228f0351787aefb76cb8f807eede3371ea2e

          Amir Shehata (amir.shehata@intel.com) uploaded a new patch: https://review.whamcloud.com/31374
          Subject: LU-10682 lnd: pending transmits dropped silently
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: fcd33574c384665e0ce6826820aff446268caa32

          gerrit Gerrit Updater added a comment - Amir Shehata (amir.shehata@intel.com) uploaded a new patch: https://review.whamcloud.com/31374 Subject: LU-10682 lnd: pending transmits dropped silently Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: fcd33574c384665e0ce6826820aff446268caa32

          People

            ashehata Amir Shehata (Inactive)
            ashehata Amir Shehata (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: