[LU-10682] o2iblnd txs can be dropped silently

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.11.0, Lustre 2.10.4
• Severity: 3
• Assignee: Amir Shehata (Inactive)
• Reporter: Amir Shehata (Inactive)

Description

2256 »·······/* grab pending txs while I have the lock */
2257 »·······list_add(&txs, &peer_ni->ibp_tx_queue);
2258 »·······list_del_init(&peer_ni->ibp_tx_queue);

This code is erroneous. We should be moving all the transmits on peer_ni->ibp_tx_queue to the local txs variable then we afterward we iterate through them and send any pending txs.

However currently these txs are simply dropped. We should be using list_splice()