[LU-10764] Incorrect code in ct_archive

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0, Lustre 2.10.4
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Oleg Drokin

Description

It contains this lovely code:

                        if (sz == 0 || strncmp(buf, dst, sz) != 0) {
                                if (unlink(src) && errno != ENOENT) {
                                        CT_ERROR(errno,
                                                 "cannot unlink symlink '%s'",
                                                 src);
                                        rcf = rcf ? rcf : -errno;
                                        goto fini_minor;
                                /* unlink old symlink done */
                                CT_TRACE("remove old symlink '%s' pointing"
                                         " to '%s'", src, buf);
                                }

Clearly we want the closing bracket after the goto, so the TRACE could be printed.

Comments

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/31667/
Subject: LU-10764 hsm: Correct debug print in ct_archive
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 70f53ec333f0f1d24fbc5b7ace691ceb66ba8506

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31667
Subject: LU-10764 hsm: Correct debug print in ct_archive
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 9d8b3a70f0dcfb6f91064b7a8f2de4791e779a5d

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31509/
Subject: LU-10764 hsm: Correct debug print in ct_archive
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: debba58308fd4c493fcde22094b4aa49b03988c1

[Oleg Drokin]

proposed patch in https://review.whamcloud.com/31509