[LU-10819] kiblnd_peer_connect_failed() uses list_add() backwards

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.12.0
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

static void
kiblnd_peer_connect_failed(kib_peer_ni_t *peer_ni, int active, int error)
...
        if (list_empty(&peer_ni->ibp_conns)) {
                /* Take peer_ni's blocked transmits to complete with error */
                list_add(&zombies, &peer_ni->ibp_tx_queue);
                list_del_init(&peer_ni->ibp_tx_queue);

                if (kiblnd_peer_active(peer_ni))
                        kiblnd_unlink_peer_locked(peer_ni);

                peer_ni->ibp_error = error;
        } else {

Issue Links

• duplicates: LU-10882 list bug in kiblnd_peer_connect_failed()

Comments

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31643/
Subject: LU-10819 o2ib: use splice in kiblnd_peer_connect_failed()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f3824b978efe810f4cca42e75f09b5a9860178c5

[John Hammond]

I see now that this code is not exactly broken just very weird. We should fix it, but it is not the cause of LU-10800.

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31643
Subject: LU-10819 o2ib: use splice in kiblnd_peer_connect_failed()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 425a0e265e611aac120f8bb119a3dd2e075d109a