[LU-10896] New static analysis issues in v2_11_50_0-51-g8d37637

• Type: Bug
• Resolution: Not a Bug
• Priority: Major
• Labels: kw
• Severity: 3
• Assignee: WC Triage
• Reporter: Dmitry Eremin (Inactive)

Description

Found 2 new static analysis issues in v2_11_50_0-51-g8d37637:

1. Pointer will be dereferenced after it was positively checked for NULL
   • lustre/mdc/mdc_dev.c: in mdc_enqueue_send, Pointer 'matched' checked for NULL at line 705 will be dereferenced at line 720.
2. Result of function that may return NULL will be dereferenced
   • lustre/mdc/mdc_dev.c: in mdc_enqueue_send, Pointer 'matched' returned from call to function 'ldlm_handle2lock' at line 704 may be NULL and will be dereferenced at line 720.

TRACEBACK:

• An event which alters the program's state, leading to the defect mdc_dev.c:705: 'matched' is checked for NULL.
• A condition which occurs, leading to the defect mdc_dev.c:705: !matched|| ( ( ( (matched) ) ->l_flags& (1<<42) ) !=0) is true
• An event which alters the program's state, leading to the defect mdc_dev.c:720: 'matched' is dereferenced by passing argument 1 to function 'ldlm_lock_put'.
  • An event which alters the program's state, leading to the defect ldlm_lock.c:189: 'lock' is passed to function 'ldlm_lock_put'.
  • An event which alters the program's state, leading to the defect ldlm_lock.c:193: 'lock' is explicitly dereferenced.

The list of commits since the previous build v2_11_0_0_RC3-0-gb2e8b97:

8d37637	LU-10833 tests: missing sed command
00c89bf	LU-6632 mgs: dont remove EXCLUDE records on lctl replace_nids
0506e1b	LU-10859 ldiskfs: fix deadlock with heavy memory preassure
c2b788e	LU-10845 kernel: kernel update [SLES12 SP3 4.4.120-94.17]
9ade609	LU-10560 mdt: remove extra headers from mdt_identity.c
faec4b0	LU-10835 tests: unload dm-flakey module
040eca6	LU-10826 ptlrpc: fix test_req_buffer_pressure behavior
2302663	LU-8913 nodemap: fix nodemap range format '*@<net>' support
2cdc1ad	LU-10566 test: fix nfs exports clean up
d57fcaf	LU-10565 osd: move ext4_tranfer_project to osd
55ed739	LU-10565 osd: unify interface for vfs
a033bd8	LU-10710 tests: fix run_write_disjoint line continuation
dd07052	LU-10565 osd: bi_error, pagevec_init, PAGE_CACHE_SHIFT changes
f3824b9	LU-10819 o2ib: use splice in kiblnd_peer_connect_failed()
320e736	LU-4939 obdclass: llog_print params file
a999892	LU-10785 llite: use xattr_handler name for ACLs
7a9a2e4	LU-10787 llite: correct removexattr detection
4753bae	LU-10788 llite: pass flags through __vfs_setxattr()
ae1be8a	LU-10792 llite: remove unused parameters from md_ {get,set} xattr()
682939f	LU-10541 llite: setxattr directly in ll_set_acl
7e3fc10	LU-10779 llite: rename FSFILT_IOC_* to system flags
c0246d8	LU-10776 osc: Do not request more than 2GiB grant
5f00d6f	LU-9444 tests: replace SINGLEMDS1 with SINGLEMDS
37f6357	LU-10629 lod: Clear OST pool with setstripe
031001f	LU-10649 llite: yield cpu after call to ll_agl_trigger
4a81be2	LU-10643 ptlrpc: ptlrpc_register_bulk() LBUG on ENOMEM
0fa1cc6	LU-10598 obdclass: ignore IGIF formatted last_id
b9a3205	LU-10560 libcfs: Use kernel_write when appropriate
33aad78	LU-10461 tests: call exit in the skip routine
9ee81f9	LU-10383 hsm: ignore compound_id
da69045	LU-10383 hsm: add action count to hsm scan data
8f8e99e	LU-10383 hsm: remove struct hsm_thread_data
96f5cc0	LU-10802 nrs: mismatch problem for wildcard in jobid TBF
101ee49	LU-9043 test: remove conf-sanity test 24a ALWAYS_EXCEPT
e0cdde1	LU-9658 ptlrpc: Add QoS for uid and gid in NRS-TBF
2cdcaa0	LU-9592 tests: remove sanity-quota tests from ALWAYS_EXCEPT
7a216e3	LU-10795 quota: fix wrong skipping of reintegration
61f9847	LU-6032 obdclass: new wrapper to convert NID to string
292aa42	LU-6032 ldlm: don't disable softirq for exp_rpc_lock
07fdba2	LU-8999 quota: fix issue of multiple call of seq start
6488c0e	LU-10698 obdclass: allow specifying complex jobids
e3bc6e6	LU-9273 tests: disable random I/O in replay-ost-single/5
b892064	LU-10264 mdc: fix possible NULL pointer dereference
7ec8e47	LU-7420 echo: fix echo server to work with unified target
6189ae0	LU-10752 build: fix rpm packaging issues for gss
8922807	LU-9551 utils: add l_tunedisk to fix disk tunings
01fb4ed	LU-10773 obdclass: yield cpu during changelog_block_trim_ext
196855e	LU-10761 osd-ldiskfs: not create REMOTE_PARENT_DIR on OST
f767214	LU-10837 ldiskfs: skip bitmap check if block bitmap is uninitialized
5b64d9f	LU-10703 nodemap: save and clear fileset correctly
543f1fb	LU-10830 utils: fix create mode for lfs setstripe
6987c10	New tag 2.11.50
1779751	New release 2.11

Issue Links

• is related to: LU-4629 Issues found by static analysis tools