Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11096

Lustre doesn't build if kernel has no blk integrity

Details

    • Improvement
    • Resolution: Fixed
    • Trivial
    • Lustre 2.12.0
    • None
    • None
    • linux-3.10.0-327.18.2.el7
    • 9223372036854775807

    Description

      wrap corresponding functionality with HAVE_BLK_INTEGRITY_ENABLED

       

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. LU-11274 Compile failure when CONFIG_BLK_DEV_INTEGRITY is unset

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-11224 T10PI assume several kernel features are enabled.

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            [LU-11096] Lustre doesn't build if kernel has no blk integrity
            pjones Peter Jones added a comment -

            Landed for 2.12

            pjones Peter Jones added a comment - Landed for 2.12
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32725/
            Subject: LU-11096 osd: wrap new blk integrity stuff
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c8505c2e70d03ba20edf9fcbf431888e87a21147

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32725/ Subject: LU-11096 osd: wrap new blk integrity stuff Project: fs/lustre-release Branch: master Current Patch Set: Commit: c8505c2e70d03ba20edf9fcbf431888e87a21147
            hornc Chris Horn added a comment -

            Not sure why we don't have a comment with the patch -  https://review.whamcloud.com/#/c/32725

            hornc Chris Horn added a comment - Not sure why we don't have a comment with the patch -  https://review.whamcloud.com/#/c/32725
            hornc Chris Horn added a comment -

            Adding my description from LU-11274 to make this more discoverable:

            Similar to LU-11224, the T10PI feature assumes that CONFIG_BLK_DEV_INTEGRITY=y is set.

            I see this on SLES 12 SP3, but presumably similar failures would occur on any kernel.

            [  232s] In file included from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lvfs.h:45:0,
[  232s]                  from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/obd.h:53,
[  232s]                  from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/fid/fid_request.c:43:
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h: In function 'blk_integrity_interval':
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h:708:11: error: dereferencing pointer to incomplete type
[  232s]   return bi->sector_size; 
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h: In function 'blk_integrity_name':
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h:717:11: error: dereferencing pointer to incomplete type
[  232s]   return bi->name;
            hornc Chris Horn added a comment - Adding my description from LU-11274 to make this more discoverable: Similar to LU-11224 , the T10PI feature assumes that CONFIG_BLK_DEV_INTEGRITY=y is set. I see this on SLES 12 SP3, but presumably similar failures would occur on any kernel. [ 232s] In file included from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lvfs.h:45:0, [ 232s] from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/obd.h:53, [ 232s] from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/fid/fid_request.c:43: [ 232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h: In function 'blk_integrity_interval': [ 232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h:708:11: error: dereferencing pointer to incomplete type [ 232s] return bi->sector_size; [ 232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h: In function 'blk_integrity_name': [ 232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h:717:11: error: dereferencing pointer to incomplete type [ 232s] return bi->name;

            People

              bzzz Alex Zhuravlev
              bzzz Alex Zhuravlev
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: