[LU-11198] “lctl get_param“ doesn't return errno when reading fails

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.12.0
• Environment: both 2.10 and master branch have the problem
• Severity: 3
• Assignee: Wang Shilong (Inactive)
• Reporter: Li Xi

Description

The problem (Or feature? I don't think it is a good feature though) is caused by a defect in param_display(). The return failure of read_param() is ignored.

 

1. lctl get_param -n ost.OSS.ost_io.nrs_tbf_rule
   error: get_param: reading 'ost.OSS.ost_io.nrs_tbf_rule': No such device
   ]# echo $?
   0

Comments

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32925/
Subject: LU-11198 utils: propagate errors for read_param
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6ca2425ccf6bf7176a37a4c93a67995479307036

[Gerrit Updater]

Wang Shilong ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32925
Subject: LU-11198 utils: propagate errors for read_param
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0e0bf55db8f269dbc6c2d7856be9c7d182fed713