Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11507

lustre doesn't build against zfs master: refcount_add missing

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: Upstream
    • Fix Version/s: Lustre 2.12.0
    • Labels:
      None
    • Environment:
      Centos 7
    • Epic/Theme:
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      The latest lustre will not build against ZFS master:

        CC [M]  /home/hutter/lustre-release/lustre/osd-zfs/osd_handler.o
       In file included from /home/hutter/lustre-release/lustre/osd-zfs/osd_handler.c:52:0:
       /home/hutter/lustre-release/lustre/osd-zfs/osd_internal.h: In function 'osd_sa_handle_get':
       /home/hutter/lustre-release/lustre/osd-zfs/osd_internal.h:929:2: error: implicit declaration of function 'refcount_add' [-Werror=implicit-function-declaration]
        refcount_add(&dn->dn_bonus->db_holds, osd_obj_tag);
      

      refcount_add was removed in ZFS in:

      Linux 4.19-rc3+ compat: Remove refcount_t compat (https://github.com/zfsonlinux/zfs/pull/7932).

      That patch is expected to be included in zfs-0.7.12 as well.

      Lustre should be updated to use zfs_refcount_add() if it exists, and then fall back to refcount_add if not.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hutter Tony Hutter
                Reporter:
                hutter Tony Hutter
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: