Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11507

lustre doesn't build against zfs master: refcount_add missing

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.12.0
    • Upstream
    • None
    • Centos 7
    • 3
    • 9223372036854775807

    Description

      The latest lustre will not build against ZFS master:

        CC [M]  /home/hutter/lustre-release/lustre/osd-zfs/osd_handler.o
       In file included from /home/hutter/lustre-release/lustre/osd-zfs/osd_handler.c:52:0:
       /home/hutter/lustre-release/lustre/osd-zfs/osd_internal.h: In function 'osd_sa_handle_get':
       /home/hutter/lustre-release/lustre/osd-zfs/osd_internal.h:929:2: error: implicit declaration of function 'refcount_add' [-Werror=implicit-function-declaration]
        refcount_add(&dn->dn_bonus->db_holds, osd_obj_tag);
      

      refcount_add was removed in ZFS in:

      Linux 4.19-rc3+ compat: Remove refcount_t compat (https://github.com/zfsonlinux/zfs/pull/7932).

      That patch is expected to be included in zfs-0.7.12 as well.

      Lustre should be updated to use zfs_refcount_add() if it exists, and then fall back to refcount_add if not.

      Attachments

        Issue Links

          Activity

            [LU-11507] lustre doesn't build against zfs master: refcount_add missing

            Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33605
            Subject: LU-11507 osd-zfs: Use zfs_refcount_add if available
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: ea49a168ec676c9b35e6a48c56d5427f51a40894

            gerrit Gerrit Updater added a comment - Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33605 Subject: LU-11507 osd-zfs: Use zfs_refcount_add if available Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: ea49a168ec676c9b35e6a48c56d5427f51a40894
            pjones Peter Jones added a comment -

            Landed for 2.12

            pjones Peter Jones added a comment - Landed for 2.12

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33359/
            Subject: LU-11507 osd-zfs: Use zfs_refcount_add if available
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 89f8ee7f964d2598939ca483f522d6918915962c

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33359/ Subject: LU-11507 osd-zfs: Use zfs_refcount_add if available Project: fs/lustre-release Branch: master Current Patch Set: Commit: 89f8ee7f964d2598939ca483f522d6918915962c

            Tony Hutter (hutter2@llnl.gov) uploaded a new patch: https://review.whamcloud.com/33359
            Subject: LU-11507 osd-zfs: Use zfs_refcount_add if available
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: f52d3e56f2338be435c434444243ae423ec06504

            gerrit Gerrit Updater added a comment - Tony Hutter (hutter2@llnl.gov) uploaded a new patch: https://review.whamcloud.com/33359 Subject: LU-11507 osd-zfs: Use zfs_refcount_add if available Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: f52d3e56f2338be435c434444243ae423ec06504
            hutter Tony Hutter added a comment -

            Sure, I'll setup a gerrit account and I submit it

            hutter Tony Hutter added a comment - Sure, I'll setup a gerrit account and I submit it
            pjones Peter Jones added a comment -

            Tony

            Can you push the patch into Gerrit so we can test/review easily and get this landed?

            Peter

            pjones Peter Jones added a comment - Tony Can you push the patch into Gerrit so we can test/review easily and get this landed? Peter
            hutter Tony Hutter added a comment -

            I uploaded a patch that works for me against zfs master.  It also needs https://github.com/zfsonlinux/zfs/pull/8014 to completely build.  I will test it against an old zfs without that patch to test the case where zfs_refcount_add does not exist.

            hutter Tony Hutter added a comment - I uploaded a patch that works for me against zfs master.  It also needs https://github.com/zfsonlinux/zfs/pull/8014 to completely build.  I will test it against an old zfs without that patch to test the case where zfs_refcount_add does not exist.

            People

              hutter Tony Hutter
              hutter Tony Hutter
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: