[LU-11536] ofd_create_hdl returns 0 instead of ENOSPC causing ESTALE on MDS

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.12.0, Lustre 2.10.7
• Severity: 3
• Assignee: Sergey Cheremencev
• Reporter: Sergey Cheremencev

Description

 

During code analysis I found that LU-6401 brakes ENOSPC handling logic in OSP. 

osp_precreate_send() returns -ESTALE when OST can't precreate objects i.e. -ENOSPACE:

        if (osp_fid_diff(fid, &d->opd_pre_used_fid) <= 0) {
                CERROR("%s: precreate fid "DFID" < local used fid "DFID": rc = %d\n", d->opd_obd->obd_name,
                       PFID(fid), PFID(&d->opd_pre_used_fid), -ESTALE);
                GOTO(out_req, rc = -ESTALE);
        }

However it is not correct. In case of -ENOSPC on OST, MDS should get -ENOSPC.
For example osp_precreat_reserve() forces local commit to release space and waits for OBD_TIMEOUT.
I think "LU-6401 uapi: fix up lustre_ostid.h and lustre_fid.h" broke this logic:

@@ -1781,7 +1781,7 @@ static int ofd_create_hdl(struct tgt_session_info *tsi)
                         granted = 0;
                 }
 
-                ostid_set_id(&rep_oa->o_oi, ofd_seq_last_oid(oseq));
+                rc = ostid_set_id(&rep_oa->o_oi, ofd_seq_last_oid(oseq));
         }
         EXIT;

After the patch OST returns 0 in case when osp_precreate_objects() returns -ENOSPC.
 

Issue Links

• is duplicated by: LU-11588 ofd_create_hdl() shouldn't overwrite error code

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33978/
Subject: LU-11536 ofd: ofd_create_hdl may return 0 in case of ENOSPC
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 496ddb5b99394142bc158b3f8b0149bcb6b6eae0

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33978
Subject: LU-11536 ofd: ofd_create_hdl may return 0 in case of ENOSPC
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 2c94faf22b1f0dca526e9e7f489cec01cbffa10c

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33390/
Subject: LU-11536 ofd: ofd_create_hdl may return 0 in case of ENOSPC
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1f97bb8e7236971aaf3029fe3699db9baf721da1

[Gerrit Updater]

Sergey Cheremencev ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33390
Subject: LU-11536 ofd: ofd_create_hdl may return 0 in case of ENOSPC
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6730d70e44daa6697cec861b7e37571eecb323a6