[LU-11588] ofd_create_hdl() shouldn't overwrite error code

• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: Alex Zhuravlev

Description

ostid_set_id() can overwrite error code from ofd_precreate_objects(). this may lead to a set of issues on MDS side (misleading error message, RPC storm, etc).

 LustreError: 26378:0:(ofd_dev.c:1784:ofd_create_hdl()) nbp13-OST0008: unable to precreate: rc = -115
 LustreError: 26378:0:(ofd_dev.c:1784:ofd_create_hdl()) Skipped 59 previous similar messages
 LustreError: 25151:0:(osp_precreate.c:657:osp_precreate_send()) nbp13-OST0008-osc-MDT0000: precreate fid [0x100080000:0x217edc:0x0] < local used fid [0x100080000:0x217edc:0x0]: rc = -116
 LustreError: 25151:0:(osp_precreate.c:657:osp_precreate_send()) Skipped 59 previous similar messages
 LustreError: 25151:0:(osp_precreate.c:1289:osp_precreate_thread()) nbp13-OST0008-osc-MDT0000: cannot precreate objects: rc = -116

The -115 = -EINPROGRESS error is because the LMA FID is bad and LFSCK has started OI Scrub. The error is not returned to the MDS, but it created no objects and hits the error in osp_precreate_send() and spins on precreate because there are no errors reported on the OST.

Issue Links

• duplicates: LU-11536 ofd_create_hdl returns 0 instead of ENOSPC causing ESTALE on MDS
• is related to: LU-11584 kernel BUG at ldiskfs.h:1907!

Comments

[Alex Zhuravlev]

that's correct

[Peter Jones]

bzzz

Do I understand correctly that this issue is fixed by LU-11536? If so, shouldn't the patch be abandoned?

Peter

[Gerrit Updater]

Alex Zhuravlev ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33525
Subject: LU-11588 ofd: keep error code in ofd_create_hdl()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 103311c099d3b39cf9e433ce9d6ee5ab1a7bb54d