Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11558

t32_verify_quota() not being called by t32_test()

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.15.0
    • Lustre 2.11.0, Lustre 2.12.0
    • None
    • 3
    • 9223372036854775807

    Description

      Since patch https://review.whamcloud.com/28020 "LU-3285 test: add Data-on-MDT tests and fixes" landed as commit v2_10_53_0-39-ga7625cd2f3 the call to t32_verify_quota() from conf-sanity.sh t32_test() has been removed, and (I'd guess) that we are no longer verifying that quota is still working correctly after an upgrade.

      It is unclear why this check was removed. It needs to be returned back to the code so that we resume testing that quota is working after an upgrade from an old disk format.

      It looks like the t32_verify_quota() function itself was broken by patch https://review.whamcloud.com/30087 "LU-7004 tests: move from lctl conf_param to lctl set_param -P" which recently landed, because that is calling "set_persistent_param_and_check $node" when it should be calling "set_persistent_param_and_check $facet" (though t32_verify_quota() is not passed a facet, so I'm not yet sure what needs to be done to fix it).

      Attachments

        Issue Links

          Activity

            [LU-11558] t32_verify_quota() not being called by t32_test()
            pjones Peter Jones added a comment -

            Landed for 2.15

            pjones Peter Jones added a comment - Landed for 2.15

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/33423/
            Subject: LU-11558 tests: re-enable conf-sanity t32_verify_quota()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 35b9575fd02f485f48793bedd5de270b826a82b1

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/33423/ Subject: LU-11558 tests: re-enable conf-sanity t32_verify_quota() Project: fs/lustre-release Branch: master Current Patch Set: Commit: 35b9575fd02f485f48793bedd5de270b826a82b1

            Patch landed for LU-7004 regression spot while resolving this problem so link is no longer needed.

            simmonsja James A Simmons added a comment - Patch landed for LU-7004 regression spot while resolving this problem so link is no longer needed.

            Faster to just push an add-on patch to my previous one, I leave it to you and Hongchao to debug any issues (hopefully none).

            adilger Andreas Dilger added a comment - Faster to just push an add-on patch to my previous one, I leave it to you and Hongchao to debug any issues (hopefully none).

            Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33423
            Subject: LU-11558 tests: re-enable conf-sanity t32_verify_quota()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 9a302ca09b3e9810a43b78628c8ac5ba7b1a5eab

            gerrit Gerrit Updater added a comment - Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33423 Subject: LU-11558 tests: re-enable conf-sanity t32_verify_quota() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 9a302ca09b3e9810a43b78628c8ac5ba7b1a5eab

            See https://review.whamcloud.com/33422 "LU-11556 tests: fix set_persistent_param_and_check breakage" as a starting point.

            adilger Andreas Dilger added a comment - See https://review.whamcloud.com/33422 " LU-11556 tests: fix set_persistent_param_and_check breakage " as a starting point.

            This first came to light in the test_32() output from LU-11556.

            adilger Andreas Dilger added a comment - This first came to light in the test_32() output from LU-11556 .

            People

              adilger Andreas Dilger
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: