[LU-11611] Incorrect return value in mdt_reint_unlink

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.12.0
• Affects Version/s: Lustre 2.12.0
• Severity: 3
• Assignee: Lai Siyao
• Reporter: Oleg Drokin

Description

Added by recent landing of https://review.whamcloud.com/31425

        /* We will lock the child regardless it is local or remote. No harm. */
        mc = mdt_object_find(info->mti_env, info->mti_mdt, child_fid);
        if (IS_ERR(mc))
                GOTO(unlock_parent, rc = PTR_ERR(mc));

        if (!cos_incompat) {
                rc = mdt_object_striped(info, mc);
                if (rc < 0)
                        GOTO(unlock_parent, rc = PTR_ERR(mc));

this last PTR_ERR should clearly be just "rc".

Issue Links

• is related to: LU-4684 DNE3: allow migrating DNE striped directory

Comments

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33577/
Subject: LU-11611 mdt: incorrect return value in mdt_reint_unlink
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 03f077a5dbcd9c4096c6f6ff1bf12b8f39a16603

[Gerrit Updater]

Lai Siyao ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33577
Subject: LU-11611 mdt: incorrect return value in mdt_reint_unlink
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 43fdc8e75d12a2fe461913f4310cefa4b842ded2

[Lai Siyao]

I'll give a fix soon.

[Peter Jones]

Lai

 

Could you please investigate?

 

Thanks

 

Peter