Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11611

Incorrect return value in mdt_reint_unlink

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.12.0
    • Lustre 2.12.0
    • None
    • 3
    • 9223372036854775807

    Description

      Added by recent landing of https://review.whamcloud.com/31425

              /* We will lock the child regardless it is local or remote. No harm. */
        mc = mdt_object_find(info->mti_env, info->mti_mdt, child_fid);
        if (IS_ERR(mc))
                GOTO(unlock_parent, rc = PTR_ERR(mc));

        if (!cos_incompat) {
                rc = mdt_object_striped(info, mc);
                if (rc < 0)
                        GOTO(unlock_parent, rc = PTR_ERR(mc));

      this last PTR_ERR should clearly be just "rc".

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-4684 DNE3: allow migrating DNE striped directory

          • Major - Major loss of function.
          • Resolved

          Activity

            [LU-11611] Incorrect return value in mdt_reint_unlink
            pjones Peter Jones made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-4684 [ LU-4684 ]
            adilger Andreas Dilger made changes -
            Description Original: Added by recent landing of https://review.whamcloud.com/31425

            {code}
                    /* We will lock the child regardless it is local or remote. No harm. */
                    mc = mdt_object_find(info->mti_env, info->mti_mdt, child_fid);
                    if (IS_ERR(mc))
                            GOTO(unlock_parent, rc = PTR_ERR(mc));

                    if (!cos_incompat) {
                            rc = mdt_object_striped(info, mc);
                            if (rc < 0)
                                    GOTO(unlock_parent, rc = PTR_ERR(mc));
            {code}

            this last PTR_ERR should clearly be PTR_ERR(rc);             		New: Added by recent landing of https://review.whamcloud.com/31425

            {code}
                    /* We will lock the child regardless it is local or remote. No harm. */
                    mc = mdt_object_find(info->mti_env, info->mti_mdt, child_fid);
                    if (IS_ERR(mc))
                            GOTO(unlock_parent, rc = PTR_ERR(mc));

                    if (!cos_incompat) {
                            rc = mdt_object_striped(info, mc);
                            if (rc < 0)
                                    GOTO(unlock_parent, rc = PTR_ERR(mc));
            {code}

            this last PTR_ERR should clearly be just "rc".
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Lai Siyao [ laisiyao ]
            green Oleg Drokin made changes -
            Fix Version/s New: Lustre 2.12.0 [ 13495 ]
            green Oleg Drokin made changes -
            Affects Version/s New: Lustre 2.12.0 [ 13495 ]
            green Oleg Drokin created issue -

            People

              laisiyao Lai Siyao
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: