Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11735

o2iblnd - bad check for fmr

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • Lustre 2.12.0
    • None
    • 3
    • 9223372036854775807

    Description

      9b790ba0f5606c0a91563828fa43f5e4ae210425 LU-11152 lnd: test fpo_fmr_poool pointer instead of special bool
      

      Introduced an issue.

      You can't perform the following check:

      if (!IS_ERR_OR_NULL(fpo->fmr.fpo_fmr_pool))
      

      because

       340 »·······union {                                           
       341 »·······»·······struct {  
       342 »·······»·······»·······struct ib_fmr_pool *fpo_fmr_pool; /* IB FMR pool */
       343 »·······»·······} fmr;                                                          
       344 »·······»·······struct { /* For fast registration */
       345 »·······»·······»·······struct list_head  fpo_pool_list;
       346 »·······»·······»·······int»····»·······  fpo_pool_size;
       347 »·······»·······} fast_reg;                                       
       348 »·······};
      

      It's part of a union so if we have fast reg enabled, then it's possible that the check is successful even though we don't have fmr enabled.

      Attachments

        Issue Links

          Activity

            People

              ashehata Amir Shehata (Inactive)
              ashehata Amir Shehata (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated: