Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11889

sanity test 156 fails on ZFS: roc_hit not safe to use

Details

    • Bug
    • Resolution: Unresolved
    • Trivial
    • None
    • Lustre 2.10.7, Lustre 2.12.1
    • None
    • zfs
    • 3
    • 9223372036854775807

    Description

      because osd-zfs doesn't maintain cache hit/miss stats, there is just no regular API for this at the moment.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-5375 Failure on test suite sanity test_151 test_156: roc_hit is not safe to use

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-2261 Add cache stats to zfs osd

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-11607 Reduce repeated function calls in Lustre test suites

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-11889] sanity test 156 fails on ZFS: roc_hit not safe to use
            bzzz Alex Zhuravlev added a comment -

            adilger I checked ZFS sources and it looks that there is no easy way to get stats for Lustre-related dbufs - all stats ZFS collects are global. We could pre-lookup dbufs and check its status, but that would be +1 lookup for every dbuf which isn't free. not sure we want to pay that price.

            bzzz Alex Zhuravlev added a comment - adilger I checked ZFS sources and it looks that there is no easy way to get stats for Lustre-related dbufs - all stats ZFS collects are global. We could pre-lookup dbufs and check its status, but that would be +1 lookup for every dbuf which isn't free. not sure we want to pay that price.
            adilger Andreas Dilger added a comment -

            Alex, is it possible to easily implement the cache_hits tracking for ZFS?

            adilger Andreas Dilger added a comment - Alex, is it possible to easily implement the cache_hits tracking for ZFS?
            gerrit Gerrit Updater added a comment -

            Andreas Dilger (adilger@whamcloud.com) merged in patch https://review.whamcloud.com/34114/
            Subject: LU-11889 tests: disable sanity/156 for ZFS OST
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 42c4dab3c817f9f03efe457fd33e946ed68fab14

            gerrit Gerrit Updater added a comment - Andreas Dilger (adilger@whamcloud.com) merged in patch https://review.whamcloud.com/34114/ Subject: LU-11889 tests: disable sanity/156 for ZFS OST Project: fs/lustre-release Branch: master Current Patch Set: Commit: 42c4dab3c817f9f03efe457fd33e946ed68fab14
            adilger Andreas Dilger added a comment -

            It looks like this bug originated in LU-2261, which enabled sanity test_156 for ZFS when brw_stats was enabled for ZFS, even though the cache_hits tunable is not actually being tracked for ZFS. The error went unnoticed because there was a syntax error in the "skip" logic until patch "LU-11607 tests: create routine to get Lustre env" landed, which properly enabled the test for ZFS and proceeded to cause all the ZFS tests to fail.

            adilger Andreas Dilger added a comment - It looks like this bug originated in LU-2261 , which enabled sanity test_156 for ZFS when brw_stats was enabled for ZFS, even though the cache_hits tunable is not actually being tracked for ZFS. The error went unnoticed because there was a syntax error in the "skip" logic until patch " LU-11607 tests: create routine to get Lustre env " landed, which properly enabled the test for ZFS and proceeded to cause all the ZFS tests to fail.
            bzzz Alex Zhuravlev added a comment -

            yes, I found number of failures like this:
            https://testing.whamcloud.com/test_sets/f337b3f4-20cb-11e9-af70-52540065bddc

            bzzz Alex Zhuravlev added a comment - yes, I found number of failures like this: https://testing.whamcloud.com/test_sets/f337b3f4-20cb-11e9-af70-52540065bddc
            adilger Andreas Dilger added a comment -

            Are there examples of this failing in autotest?

            adilger Andreas Dilger added a comment - Are there examples of this failing in autotest?
            gerrit Gerrit Updater added a comment -

            Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34114
            Subject: LU-11889 tests: disable sanity/156 for ZFS OST
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: e138216b361324b2fb4da7384b07f6f086d29649

            gerrit Gerrit Updater added a comment - Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34114 Subject: LU-11889 tests: disable sanity/156 for ZFS OST Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: e138216b361324b2fb4da7384b07f6f086d29649

            People

              bzzz Alex Zhuravlev
              bzzz Alex Zhuravlev
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: