[LU-11898] libcfs module parameter libcfs_debug_mb has no effect

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0
• Severity: 3
• Assignee: Vladimir Saveliev
• Reporter: Vladimir Saveliev

Description

debug_mb is libcfs module parameter. It should be possible to set it
via

modprobe libcfs libcfs_debug_mb=800

or via adding

options libcfs libcfs_debug_mb=800

to modules configuration.

libcfs_debug_init, however, calculated libcfs_debug_mb unconditionally, so that the module parameter makes no effect:

int libcfs_debug_init(unsigned long bufsize)
...
        libcfs_debug_mb = cfs_trace_get_debug_mb();
...

Issue Links

• is related to: LU-8066 Move lustre procfs handling to sysfs and debugfs.

Comments

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34128/
Subject: LU-11898 libcfs: do not calculate debug_mb if it is set
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: adeb29400a4a6466e45cb8c793500ae6d37ed642

[James A Simmons]

Are you seeing the module value modified or completely ignored. In my testing I see a modified value of debug_mb.

[Gerrit Updater]

Vladimir Saveliev ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34128
Subject: LU-11898 libcfs: do not calculate debug_mb if it is set
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e657421403664919848b0c72eb50edbe4bd7a62c