[LU-11919] cl_max_dirty_pages not zeroed on startup

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.1
• Severity: 3
• Assignee: Patrick Farrell (Inactive)
• Reporter: Patrick Farrell (Inactive)

Description

cl_dirty_max_pages (the internal representation of max_dirty_mb) is not zeroed at initialization.  The function client_adjust_max_dirty is called, but it only sets it if the value is <= 0, which will be true most of the time for random memory...  But not all of the time.

So sometimes cl_max_dirty_pages ends up at some random positive value.  Easy fix.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34458/
Subject: LU-11919 llite: Initialize cl_dirty_max_pages
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 7c8d60106acd5a781660a05fef7612a7db5b243f

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34458
Subject: LU-11919 llite: Initialize cl_dirty_max_pages
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: f5c0d51c8e372de438a2c469e9cfbfc96d888ccd

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34173/
Subject: LU-11919 llite: Initialize cl_dirty_max_pages
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2e9c896dec6d5c582c5dd24d3026e8324dfa807c

[Gerrit Updater]

Patrick Farrell ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34173
Subject: LU-11919 llite: Initialize cl_dirty_max_pages
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6f7ceb99574ddf136f18ba77c3a3c41887464529

[Patrick Farrell (Inactive)]

This is the issue causing the odd max_dirty_mb values.  (The grant request issue is separate and should still be fixed with that patch.)