[LU-11930] sbi_flags printing broke

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.1
• Affects Version/s: Lustre 2.13.0
• Severity: 3
• Assignee: Patrick Farrell (Inactive)
• Reporter: Oleg Drokin

Description

Nowadays if we do get_param on lustre-....sbi_flags we get back:

error: get_param: reading 'llite.lustre-ffff88009a0ca800.sbi_flags': Invalid argument

and then in the kernel

[  788.311079] LustreError: 10351:0:(lproc_llite.c:967:ll_sbi_flags_seq_show()) lustre: Revise array LL_SBI_FLAGS to match sbi flags please.

The result is of course every test that checks feature flags is now not finding anything it's looking for and skips. in particular al layoutswaps (test 184*) and a bunch of other stuff is now in perma-skip mode.

This was broken in LU-11825 https://review.whamcloud.com/33912 it appears by removing a flag from LL_SBI_FLAGS which is something that should NEVER be done.

Also I think we ned to convert that error message into an assertion.

Problems like here we'd catch sooner and if some client has some flags set incorrectly we are probably ok panicking there as well as there's clearly some unexpected memory corruption or whatnot going on?

Issue Links

• is related to: LU-12262 Improve sbi_flags checking

Comments

[Peter Jones]

The bug is fixed. pfarrell can you please create a new ticket to track the cleanups.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34472/
Subject: LU-11930 llite: Restore pio flags
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 845338af031a26f4b42fa21352183bd4709ebddc

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34472
Subject: LU-11930 llite: Restore pio flags
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 27ff659a4564b91f11ffed9175d5ec36dde6bdb5

[Andreas Dilger]

Assign to Patrick for minor cleanups discussed in patch.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34187/
Subject: LU-11930 llite: Restore pio flags
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 045c1a968a0478ee57aaa61deed8ec563bf50002

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34188
Subject: LU-11930 llite: Assert on unknown flags in ll_sbi_flags_seq_show()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f640203e8356f841ebe5ce3e59cc33ab3f237ba5

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34187
Subject: LU-11930 llite: Restore pio flags
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4d704903762f09cffaa13c9599130419aced19f6