[LU-12269] Support RHEL 8.0

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Labels: llnl
• Severity: 3
• Assignee: Jian Yu
• Reporter: Jian Yu

Description

Red Hat Enterprise Linux 8.0 is general available today:
https://access.redhat.com/announcements/4110231
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.0_release_notes/index

Issue Links

• is related to: LU-11594 sanity test_103a: FAIL: permissions failed
• is related to: LU-12398 sanity test_255b: FAIL: Ladvise willread should use more memory than 76800 KiB
• is related to: LU-12399 sanity test_420: FAIL: incorrect perms on /mnt/lustre/d420.sanity/testdir/testfile
• is related to: LU-12456 kernel update [RHEL8.0 4.18.0-80.4.2.el8_0]
• is related to: LU-12657 sanity/103 and sanityn/25 fail with 4.18 kernel
• is related to: LU-12403 add e2fsprog support for RHEL-8
• is related to: LU-12270 Support linux kernel version 4.19
• is related to: LU-12331 hardened usercopy whitelisting
• is related to: LU-10073 lnet-selftest test_smoke: lst Error found
• is related to: LU-12395 Failed dependencies while installing lustre-client-tests and lustre-iokit rpms on RHEL 8.0 client
• is related to: LU-11893 doesn't handle logical network interface properly.
• is related to: LU-12396 lfs df output is treated as binary data on RHEL 8.0 client
• is related to: LU-11838 Support linux kernel version 4.18
• is related to: LU-12509 lockdep warning in ofd_precreate_objects()
• is related to: LU-11233 gcc8 support

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34883/
Subject: LU-12269 build: remove %

{fullrelease}

from Provides
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 48e16113731a1a9fff06370a0a11ea083ad290b8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34882/
Subject: LU-12269 build: fix hardened builds in rpm spec file
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5270583ae6e436e9e7ae0199312e7f50365744af

[Jian Yu]

After applying the following patches to the latest master branch, RHEL 8.0 Lustre client build passed: https://build.whamcloud.com/job/lustre-reviews/64783/

• https://review.whamcloud.com/34882 (LU-12269 build: fix hardened builds in rpm spec file)
• https://review.whamcloud.com/34883 (LU-12269 build: remove %{fullrelease} from Provides)
• https://review.whamcloud.com/34892 (LU-12269 build: add value to definition of with_gss in spec)
• https://review.whamcloud.com/34827 (LU-12270 o2iblnd: pci_unmap_addr() removed in 4.19)
• https://review.whamcloud.com/34392 (LU-11893 ksocklnd: add secondary IP address handling)
• https://review.whamcloud.com/34234 (LU-11838: lnet: remove lnet_ipif_enumerate())
• https://review.whamcloud.com/34673 (LU-11838 llite: address_space ->page_tree renamed ->i_pages)
• https://review.whamcloud.com/34661 (LU-11233 tests: fix gcc8 build warnings)
• https://review.whamcloud.com/34662 (LU-11233 utils: fix build warnings for gcc8)
• https://review.whamcloud.com/34862 (LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8])

[Jian Yu]

Thank you, Yang Sheng and James.

[James A Simmons]

You need the LU-11233 patches.

https://review.whamcloud.com/#/c/34661/

https://review.whamcloud.com/#/c/34662/

[Yang Sheng]

Hi, Yujian,

Yes, Since it was substituted from EXTRA_KCFLAGS and please note that part only apply to kernel build(when PATCHLEVEL no NULL).

Thanks,
YangSheng

[Jian Yu]

I see, Yang Sheng, so that might be the reason. However, I saw those flags were also specified in EXTRA_CFLAGS in lustre-relase/Rules:

EXTRA_CFLAGS := $(EXTRA_PRE_CFLAGS)
EXTRA_CFLAGS += -include /root/lustre-release/undef.h -include /root/lustre-release/config.h  -g -I/root/lustre-release/libcfs/include -I/root/lustre-release/lnet/include -I/root/lustre-release/lustre/include -Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow -g -O2 -Wall -Werror
EXTRA_CFLAGS += $(EXTRA_POST_CFLAGS)

[Yang Sheng]

Hi, Yujian,

EXTRA_KCFLAGS should only impact kernel build process. Are you sure it also is effect in user environment?

Thanks,
YangSheng

[Jian Yu]

I incorporated the above patches into a for-test-only patch in https://review.whamcloud.com/34908 to verify. Jenkins build failed as follows:

00:35:12 liblnetconfig.c: In function 'yaml_copy_peer_nids':
00:35:12 liblnetconfig.c:4321:3: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
00:35:12    strncpy(nids[num], entry->cy_valuestring,
00:35:12    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
00:35:12     strlen(entry->cy_valuestring));
00:35:12     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
00:35:12 liblnetconfig.c: In function 'lnet_expr2ips':
00:35:12 liblnetconfig.c:722:30: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size 104 [-Werror=format-truncation=]
00:35:12     "\"cannot parse ip_range '%s'\"", ip_range);
00:35:12                               ^~      ~~~~~~~~
00:35:12 liblnetconfig.c:720:3: note: 'snprintf' output between 27 and 154 bytes into a destination of size 128
00:35:12    snprintf(err_str,
00:35:12    ^~~~~~~~~~~~~~~~~
00:35:12     LNET_MAX_STR_LEN,
00:35:12     ~~~~~~~~~~~~~~~~~
00:35:12     "\"cannot parse ip_range '%s'\"", ip_range);
00:35:12     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
00:35:12 cc1: all warnings being treated as errors

However, the output of configure was:

00:21:24 checking for -Wno-format-truncation support... yes
00:21:24 checking for -Wno-stringop-truncation support... yes
00:21:24 checking for -Wno-stringop-overflow support... yes
<~snip~>
00:21:28 EXTRA_KCFLAGS: -include /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/undef.h -include /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/config.h  -g -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/libcfs/include -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/lnet/include -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/lustre/include -Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow

The "-Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow" were specified. Not sure why they did not work.

In manual build, I specified them in CFLAGS and they worked.

[Jian Yu]

After applying the following patches to the latest master branch, manual build passed:

• https://review.whamcloud.com/34882 (LU-12269 build: fix hardened builds in rpm spec file)
• https://review.whamcloud.com/34883 (LU-12269 build: remove %{fullrelease} from Provides)
• https://review.whamcloud.com/34892 (LU-12269 build: add value to definition of with_gss in spec)
• https://review.whamcloud.com/34827 (LU-12270 o2iblnd: pci_unmap_addr() removed in 4.19)
• https://review.whamcloud.com/34392 (LU-11893 ksocklnd: add secondary IP address handling)
• https://review.whamcloud.com/34234 (LU-11838: lnet: remove lnet_ipif_enumerate())
• https://review.whamcloud.com/34673 (LU-11838 llite: address_space ->page_tree renamed ->i_pages)
• https://review.whamcloud.com/34862 (LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8])

[Gerrit Updater]

Ben Menadue ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34892
Subject: LU-12269 build: add value to definition of with_gss in spec
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ddb3fa2a5169fa01c9c45b012915890ca870aaa5