[LU-12474] racer can't be found on Ubuntu 18.04

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.5
• Affects Version/s: Lustre 2.13.0, Lustre 2.12.4
• Labels: rhel8 ubuntu
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: James Nunez (Inactive)

Description

For Ubuntu 18.04, racer test suite is skipped due to not being able to find the executable.

Looking at the skipped test suite suite_log at https://testing.whamcloud.com/test_sets/9b4f1cec-272c-11e9-a318-52540065bddc ,

PATH=/usr/lib64/lustre/tests:/usr/lib/lustre/tests:/usr/lib64/lustre/tests:/opt/iozone/bin:/opt/iozone/bin:/usr/lib64/lustre/tests/mpi:/usr/lib64/lustre/tests/racer:/usr/lib64/lustre/../lustre-iokit/sgpdd-survey:/usr/lib64/lustre/tests:/usr/lib64/lustre/utils/gss:/usr/lib64/lustre/utils:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/sbin:/sbin::/sbin:/bin:/usr/sbin: NAME=autotest_config bash rpc.sh _check_progs_installed /usr/lib64/lustre/tests/racer/racer.sh 
trevis-5vm9: trevis-5vm9.trevis.whamcloud.com: executing _check_progs_installed /usr/lib64/lustre/tests/racer/racer.sh
trevis-5vm10: trevis-5vm10.trevis.whamcloud.com: executing _check_progs_installed /usr/lib64/lustre/tests/racer/racer.sh
trevis-5vm10: /usr/lib64/lustre/tests/test-framework.sh: line 2620: /usr/lib64/lustre/tests/racer/racer.sh: bad substitution
trevis-5vm9: /usr/lib64/lustre/tests/test-framework.sh: line 2620: /usr/lib64/lustre/tests/racer/racer.sh: bad substitution

 SKIP: racer  /usr/lib64/lustre/tests/racer/racer.sh not found

Issue Links

• is related to: LU-10997 Ubuntu 18 support

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37521/
Subject: LU-12474 tests: Do not run check_progs_installed for racer
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: dffe42a410907603bf392e86bc3d27fe80ae621a

[Gerrit Updater]

James Nunez ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37521
Subject: LU-12474 tests: Do not run check_progs_installed for racer
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: b56cab6b1929d5b14f503b391364e4a5a907c1b1

[Jian Yu]

The failure also occurred on Lustre b2_12 branch with RHEL 8.1 client:
https://testing.whamcloud.com/test_sets/7678e86a-3ea7-11ea-9543-52540065bddc

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35327/
Subject: LU-12474 tests: Do not run check_progs_installed for racer
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e7b7433571a748cdc651c5f50f01ff5ee0656c28

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35327
Subject: LU-12474 tests: Do not run check_progs_installed for racer
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ed188eacabc35e0a129cbc0886a0b521d6347fea

[Oleg Drokin]

This seems to be a generic problem in newer distros of the arcane indirect variable feature in bash:

{!blah}

In the end I suspect the use of check_progs_installed() in racer.sh is in error as it was never fully designed to be used with full pathnames?

added by 3a84f1d934e471f2ca6fb4c68a0e674651adf73e in LU-1187

Instead since we always have the full pathname, we should just at most check the path is valid?

even more, the test seems to be superfluous since we check for racer/racer.sh from racer.sh...