Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12780

Avoid using ptlrpc_thread where is in't needed

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Rank (Obsolete):
      9223372036854775807

      Description

      Several places in lustre use 'struct ptlrpc_thread' to "help" manage a kthread.

      These places are not directly related to ptlrpc, so the naming is not help, and in general the usage of ptlrpc_thread does not improve the code.

      By removing the use of ptlrpc_thread - particularly by avoiding startup synchornization and by using kthread_stop/ kthread_should_stop(), I can reduce code size by a couple of hundred lines.

      Using the seemly uniform approach of ptlrpc_thread can lead to an impression that these threads are all managed much the same way, but this is not the case.  There is substantial variety on how the threads work and exposing that clear will benefit maintainability.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                neilb Neil Brown
                Reporter:
                neilb Neil Brown
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: