[LU-13986] livelock is possible in distribute_txn_commit_thread()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Severity: 3
• Assignee: Neil Brown
• Reporter: Neil Brown

Description

A recent patch to update_trans.c changed how distribute_txn_thread() waited for more work to do.

It previously had an explicit "wait_event()" which listed all the conditions to wait for. It would then recheck each condition and possibly perform an appropriate action.

It was changed to check each condition only once (per loop). If the condition was true, the action would be performed and a flag set. If no conditions were true (indicated by flag), it would wait, otherwise it would loop and recheck all condition.

One of the "if (condition) { do work }" stanzas in the loop tested a condition that was not a condition that should wake up the loop. "batchid" was not tested at all in the wait_event(). The flag mentioned above was, however, set when that condition tested true.
This can cause the loop to spin indefinitely.

The "__set_current_state(TASK_RUNNING);" should be removed so that the value
of batchid cannot stop the loop from sleeping (calling 'schedule()').

Issue Links

• is related to: LU-12780 Avoid using ptlrpc_thread where is in't needed