[LU-12780] Avoid using ptlrpc_thread where is in't needed

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Assignee: Neil Brown
• Reporter: Neil Brown

Description

Several places in lustre use 'struct ptlrpc_thread' to "help" manage a kthread.

These places are not directly related to ptlrpc, so the naming is not help, and in general the usage of ptlrpc_thread does not improve the code.

By removing the use of ptlrpc_thread - particularly by avoiding startup synchornization and by using kthread_stop/ kthread_should_stop(), I can reduce code size by a couple of hundred lines.

Using the seemly uniform approach of ptlrpc_thread can lead to an impression that these threads are all managed much the same way, but this is not the case.  There is substantial variety on how the threads work and exposing that clear will benefit maintainability.

 

Issue Links

• is related to: LU-13986 livelock is possible in distribute_txn_commit_thread()
• is related to: LU-12511 Prepare lustre for adoption into the linux kernel

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38974/
Subject: LU-12780 scrub: all update to bitfields must be protected.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 23a6e1ed8eec2c07653ed07c35bb109ecb87a5b7

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38974
Subject: LU-12780 scrub: all update to bitfields must be protected.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f8ff777659f2152528085c77789c08fcca81301d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38612/
Subject: LU-12780 quota: don't use ptlrpc_thead of qmt_pool_recalc
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d9094cf66b54c953416969e8581e1f3a6df461b0

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38824
Subject: LU-12780 osd: use native kthreads for scrub.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 562bf522f156df53d4d298fd9b144398301b50d8

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38612
Subject: LU-12780 quota: don't use ptlrpc_thead of qmt_pool_recalc
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6fa73578014258098e0f86e8b448d8fbb2290a8d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36260/
Subject: LU-12780 target: don't use ptlrpc_thread for txn_commit_thread
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8bbcfedcba1d5e4401bcfd8e60936efea262d562

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36265/
Subject: LU-12780 osp: don't use ptlrpc_thread for osp_sync_thread()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8afc9590a78f6b20c338c027e17043bb22012817

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36556/
Subject: LU-12780 quota: don't use ptlrpc_thread for qmt_reba_thread
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 43046d2732a33f81390901acc87fb28920d3864f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36267/
Subject: LU-12780 quota: don't use ptlrpc_thread for qsd_upd_thread()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 2ddb1b57670ce239b755e8a7fb4f5cc9d6319786

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36268/
Subject: LU-12780 quota: don't use ptlrpc_thread for qsd_reint_main()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 24eeeeef5d56f05b19c94fdd69a5a22ab7384616

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36266/
Subject: LU-12780 osp: don't use ptlrpc_thread for lwp_notify_main()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 051f0adeb0615da83c819ff74da467bb4117ae63