[LU-12885] improve variable naming to clarify code usage - Whamcloud Community JIRA

Details

Type: Improvement
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: None
Labels:
None

Rank (Obsolete):
9223372036854775807

Description

There are lots of places in the code that have very generic variable names like "flags" or "mask" that are confusing to distinguish in places, because it isn't clear what the type of values those flags hold.

Add named enums for the variables where possible to make it very clear what type of flag is being used, and/or rename the variable to help make this clear. In a couple of cases the variable type is determined by the kernel API and cannot be changed.

Attachments

Activity

[LU-12885] improve variable naming to clarify code usage

Gerrit Updater added a comment - 02/May/25 2:17 AM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/45924/
Subject: LU-12885 llite: add enum ll_file_flags for clarity
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 33e6c43e4c8739885bd6329f350148d8324563bd

Gerrit Updater added a comment - 02/May/25 2:17 AM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/45924/ Subject: LU-12885 llite: add enum ll_file_flags for clarity Project: fs/lustre-release Branch: master Current Patch Set: Commit: 33e6c43e4c8739885bd6329f350148d8324563bd

Gerrit Updater added a comment - 13/Mar/25 5:06 PM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56812/
Subject: LU-12885 mds: add enums for MDS_OPEN flags (4/4)
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 19a2573e16335ab7ea1d6f1813b9db87f732f49a

Gerrit Updater added a comment - 13/Mar/25 5:06 PM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56812/ Subject: LU-12885 mds: add enums for MDS_OPEN flags (4/4) Project: fs/lustre-release Branch: master Current Patch Set: Commit: 19a2573e16335ab7ea1d6f1813b9db87f732f49a

Gerrit Updater added a comment - 02/Feb/25 6:26 AM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56534/
Subject: LU-12885 mds: add enums for MDS_OPEN flags (3/4)
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 948fcacd8be4e915219ada19e492e26486a231d3

Gerrit Updater added a comment - 02/Feb/25 6:26 AM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56534/ Subject: LU-12885 mds: add enums for MDS_OPEN flags (3/4) Project: fs/lustre-release Branch: master Current Patch Set: Commit: 948fcacd8be4e915219ada19e492e26486a231d3

Gerrit Updater added a comment - 29/Oct/24 10:21 AM

"Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56812
Subject: LU-12885 mds: add enums for MDS_OPEN flags (4/4)
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 53ad6aa1eb4ae94b9bedfb64a82a1ca7a85d54fb

Gerrit Updater added a comment - 29/Oct/24 10:21 AM "Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56812 Subject: LU-12885 mds: add enums for MDS_OPEN flags (4/4) Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 53ad6aa1eb4ae94b9bedfb64a82a1ca7a85d54fb

Gerrit Updater added a comment - 29/Sep/24 3:38 PM

"Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56534
Subject: LU-12885 mds: add enums for MDS_OPEN flags (3/4)
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5d8fee80cd5040822941dca5b44e01ec9472aaf4

Gerrit Updater added a comment - 29/Sep/24 3:38 PM "Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56534 Subject: LU-12885 mds: add enums for MDS_OPEN flags (3/4) Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 5d8fee80cd5040822941dca5b44e01ec9472aaf4

Gerrit Updater added a comment - 23/Aug/24 9:58 PM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55066/
Subject: LU-12885 mds: add enums for MDS_OPEN flags (2/4)
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 98edbac99ad44057bb26f5da8ffa1c63539f388c

Gerrit Updater added a comment - 23/Aug/24 9:58 PM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/55066/ Subject: LU-12885 mds: add enums for MDS_OPEN flags (2/4) Project: fs/lustre-release Branch: master Current Patch Set: Commit: 98edbac99ad44057bb26f5da8ffa1c63539f388c

Gerrit Updater added a comment - 21/May/24 6:21 PM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/36469/
Subject: LU-12885 mds: add enums for MDS_OPEN flags
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7e499228df5f9c39393ed003ff97c93a1f11c79f

Gerrit Updater added a comment - 21/May/24 6:21 PM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/36469/ Subject: LU-12885 mds: add enums for MDS_OPEN flags Project: fs/lustre-release Branch: master Current Patch Set: Commit: 7e499228df5f9c39393ed003ff97c93a1f11c79f

Gerrit Updater added a comment - 10/May/24 8:22 AM

"Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55066
Subject: LU-12885 mds: add enums for MDS_OPEN flags (2/4)
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: be0689814f427f6838a4de4183d799e85e5c4d7c

Gerrit Updater added a comment - 10/May/24 8:22 AM "Arshad Hussain <arshad.hussain@aeoncomputing.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/55066 Subject: LU-12885 mds: add enums for MDS_OPEN flags (2/4) Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: be0689814f427f6838a4de4183d799e85e5c4d7c

Gerrit Updater added a comment - 22/Apr/23 5:28 PM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/36522/
Subject: LU-12885 mdd: only bottom of clf_flags in changelog
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3b43457cf150c03c496be72265d09574ea470308

Gerrit Updater added a comment - 22/Apr/23 5:28 PM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/36522/ Subject: LU-12885 mdd: only bottom of clf_flags in changelog Project: fs/lustre-release Branch: master Current Patch Set: Commit: 3b43457cf150c03c496be72265d09574ea470308

Gerrit Updater added a comment - 23/Dec/21 8:15 AM

"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/45924
Subject: LU-12885 llite: add enum ll_file_flags for clarity
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c73f2401ae794d1186568b43871cdfe61703ec16

Gerrit Updater added a comment - 23/Dec/21 8:15 AM "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/45924 Subject: LU-12885 llite: add enum ll_file_flags for clarity Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c73f2401ae794d1186568b43871cdfe61703ec16

People

Assignee:: Andreas Dilger

Reporter:: Andreas Dilger

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 19/Oct/19 8:30 AM

Updated:: 02/May/25 2:17 AM