[LU-12885] improve variable naming to clarify code usage

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Assignee: Andreas Dilger
• Reporter: Andreas Dilger

Description

There are lots of places in the code that have very generic variable names like "flags" or "mask" that are confusing to distinguish in places, because it isn't clear what the type of values those flags hold.

Add named enums for the variables where possible to make it very clear what type of flag is being used, and/or rename the variable to help make this clear. In a couple of cases the variable type is determined by the kernel API and cannot be changed.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/33512/
Subject: LU-12885 mds: add enums for MDS_ATTR flags
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6c6b8cb972ac92c08dd91d25e57cc6a3703d951e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36520/
Subject: LU-12885 mdd: clearly name variables for MAY_ flags
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 76b9cf2565eb7a5dff65bf508d5762a109345f5d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36519/
Subject: LU-12885 llite: mark extended attr and inode flags
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b51a1e1140cac80c0590183be05e905bf87294d4

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40008
Subject: LU-12885 osd: rename xattr operation flags consistently
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0420d3815133f5264801cc524dd2064e29bbb31a

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36524
Subject: LU-12885 llapi: use enum llapi_layout_get_flags
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e49613a28af050a33a021333fda3b3bf082ba15d

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36523
Subject: LU-12885 osd: rename xattr operation flags consistently
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 39a42d686a18c442c3434b1751ddee9f806783c9

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36522
Subject: LU-12885 mdd: only bottom of clf_flags in changelog
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 101e948642bf64c3985be6e6930c7c26e36e6c33

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36521
Subject: LU-12885 mdc: remove flags argument from pack functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 901e6431093d67f3ff3f55afd22d487cdf1dfac0

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36520
Subject: LU-12885 mdd: clearly name variables for MAY_ flags
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1249c8fb774a5aa0aaac0521f31b9162db3fc29f

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36519
Subject: LU-12885 llite: mark extended attr and inode flags
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 217db7daafc917a14b150884e61cd3cc17662105