Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12931

Fix minor errors with cfs_time_seconds usage

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • Lustre 2.11.0, Lustre 2.12.0, Lustre 2.13.0
    • Lustre 2.14.0
    • 9223372036854775807

    Description

      cfs_time_seconds() converts seconds to jiffies.

      Unfortunately the name might suggest it returns seconds, rather than consumes them, so it is worth while doing an occasion audit to make sure it isn't being misused.

      At time of writing there is one place (in delayed_msg_check) where it is used but not needed (we have seconds and want seconds), and two places (ptl_recover_import and mgc_process_log) where the returned value is stored in a variable called "sec".  The variable is used correctly as jiffies, but the name is confusing.

      These irregularities should be fixed.

      Attachments

        Issue Links

          Activity

            People

              neilb Neil Brown
              neilb Neil Brown
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: