Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-13274

Building againt lustreapi using -std=c99

Details

    • 9223372036854775807

    Description

      An application that uses the compiler flag -std=c99 wants to link against lustreapi. This was possible in version 2.8. Current versions of lustreapi use the linux kernel macro __ALIGN_KERNEL() which contains the gnuism typeof, as opposed the ISO version __typeof__. For older kernels that don't define ___ALIGN_KERNEL(), Lustre conditionally defines it.

      The "simplest" fix would be for the application to add -Dtypeof=__typeof__, however, this would require figuring out where in the build system to add such a flag. The other option would be to change Lustre and redefine typeof to __typeof__ in the source code of the files that use __ALIGN_KERNEL() or maybe somewhere in the Lustre build system.

      Are there assumptions about the C version that is used by applications that use lustreapi?

       

       

       

      Attachments

        Issue Links

          Activity

            [LU-13274] Building againt lustreapi using -std=c99

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38520/
            Subject: LU-13274 uapi: fix build on older kernels
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: fd34cb106a601cf1c71cfb46a9887a5d0ba2e46f

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38520/ Subject: LU-13274 uapi: fix build on older kernels Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: fd34cb106a601cf1c71cfb46a9887a5d0ba2e46f

            Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38520
            Subject: LU-13274 uapi: fix build on older kernels
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: ead42b98dcef1844cc4790227c7ad1b58b88594d

            gerrit Gerrit Updater added a comment - Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/38520 Subject: LU-13274 uapi: fix build on older kernels Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: ead42b98dcef1844cc4790227c7ad1b58b88594d

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38215/
            Subject: LU-13274 uapi: make lustre UAPI headers pass CONFIG_UAPI_HEADER_TEST
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: b93ef29660b6ac69d7ffd0f325be02c18835b4d2

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38215/ Subject: LU-13274 uapi: make lustre UAPI headers pass CONFIG_UAPI_HEADER_TEST Project: fs/lustre-release Branch: master Current Patch Set: Commit: b93ef29660b6ac69d7ffd0f325be02c18835b4d2

            James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/38215
            Subject: LU-13274 uapi: make lustre UAPI headers pass CONFIG_UAPI_HEADER_TEST
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 1d1f901b6ddc155832533f891cf24eba16b0ccd9

            gerrit Gerrit Updater added a comment - James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/38215 Subject: LU-13274 uapi: make lustre UAPI headers pass CONFIG_UAPI_HEADER_TEST Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 1d1f901b6ddc155832533f891cf24eba16b0ccd9

            One last patch is coming.

            simmonsja James A Simmons added a comment - One last patch is coming.
            pjones Peter Jones added a comment -

            simmonsja is there more to come on this ticket?

            pjones Peter Jones added a comment - simmonsja is there more to come on this ticket?

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37971/
            Subject: LU-13274 uapi: make lnet UAPI headers C99 compliant
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 742897a967cff5be53c447d14b17ae405c2b31f2

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37971/ Subject: LU-13274 uapi: make lnet UAPI headers C99 compliant Project: fs/lustre-release Branch: master Current Patch Set: Commit: 742897a967cff5be53c447d14b17ae405c2b31f2

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37973/
            Subject: LU-13274 uapi: make lustre UAPI headers C99 compliant
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: 0417dce9fc75ad8368b6a60fb8dd9556254e2741

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37973/ Subject: LU-13274 uapi: make lustre UAPI headers C99 compliant Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 0417dce9fc75ad8368b6a60fb8dd9556254e2741

            Gian-Carlo DeFazio (defazio1@llnl.gov) uploaded a new patch: https://review.whamcloud.com/37973
            Subject: LU-13274 uapi: make lustre UAPI headers C99 compliant
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 98c09a4a057d05500e739a4e6f128661a74ad713

            gerrit Gerrit Updater added a comment - Gian-Carlo DeFazio (defazio1@llnl.gov) uploaded a new patch: https://review.whamcloud.com/37973 Subject: LU-13274 uapi: make lustre UAPI headers C99 compliant Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 98c09a4a057d05500e739a4e6f128661a74ad713

            James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37971
            Subject: LU-13274 uapi: make lnet UAPI headers C99 compliant
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 6534401add98d741807cd44f1af4152c1ce14eed

            gerrit Gerrit Updater added a comment - James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/37971 Subject: LU-13274 uapi: make lnet UAPI headers C99 compliant Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 6534401add98d741807cd44f1af4152c1ce14eed

            People

              simmonsja James A Simmons
              defazio Gian-Carlo Defazio
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: