[LU-13430] Rework __vfs_getxattr/__vfs_setxattr/__vfs_removexattr support

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Affects Version/s: Lustre 2.14.0
• Labels: patch
• Severity: 3
• Assignee: Sebastien Buisson
• Reporter: Sebastien Buisson

Description

Instead of checking everywhere in the code whether kernel defines

__vfs_getxattr/__vfs_setxattr/__vfs_removexattr

define compat macros to handle this in lustre_compat.h.

Issue Links

• is related to: LU-13465 Interop 2.12 <-> master sanity test_27A: lfs setstripe: setstripe error for '/mnt/lustre': Unknown error 524

Comments

[Alex Zhuravlev]

vfs_setxattr() and __vfs_removexattr() grab inode's lock and that can cause a deadlock - LU-17546

[Sebastien Buisson]

As far as I remember, yes, to cleanup code. And it was later fixed by patch "LU-13465 vfs: make ll_vfs_setxattr return -EOPNOTSUPP".
Why are you asking?

[Alex Zhuravlev]

what was the reason for this patch? is it a code cleanup only?

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38175/
Subject: LU-13430 vfs: add ll_vfs_getxattr/ll_vfs_setxattr compat macro
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: dcd5607ce0b35c256a7e2ec7cdca642961219c07

[Gerrit Updater]

Sebastien Buisson ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38175
Subject: LU-13430 vfs: add ll_vfs_getxattr/ll_vfs_setxattr compat macro
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 34a5fd14fe05cc643e42ee9ca5e324e83dc83efb