[LU-13977] sanity test_255a uses integer comparison for non-integers

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.14.0
• Assignee: Neil Brown
• Reporter: Neil Brown

Description

The "-gt" option in the shell "['" (aka "test") command compares integers.

ladvise_willread_performance() in sanity.sh uses "scale=2" to ask bc to calculate values to 2 decimal places.  These values are then compared with "-gt" which will fail (unless by luck they are integers).

This failure is not normally noticed as the error is only reported when no vm is detected.  (When I run qemu, no vm is detected, so I notice.)

Issue Links

• is duplicated by: LU-15316 sanity test_255a: dmidecode: command not found

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/40001/
Subject: LU-13977 tests: fix float comparison in sanity test_255a
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f3b8f3fad502354bed7c3f743e5346200f7a584e

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40001
Subject: LU-13977 tests: fix float comparison in sanity test_255a
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2033764e3fbbcc75de125121f4b57e262808d317