Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-13977

sanity test_255a uses integer comparison for non-integers

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.14.0
    • None
    • None
    • 9223372036854775807

    Description

      The "-gt" option in the shell "['" (aka "test") command compares integers.

      ladvise_willread_performance() in sanity.sh uses "scale=2" to ask bc to calculate values to 2 decimal places.  These values are then compared with "-gt" which will fail (unless by luck they are integers).

      This failure is not normally noticed as the error is only reported when no vm is detected.  (When I run qemu, no vm is detected, so I notice.)

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. LU-15316 sanity test_255a: dmidecode: command not found

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-13977] sanity test_255a uses integer comparison for non-integers
            adilger Andreas Dilger made changes -
            Link New: This issue is duplicated by LU-15316 [ LU-15316 ]
            simmonsja James A Simmons made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            simmonsja James A Simmons made changes -
            Fix Version/s New: Lustre 2.14.0 [ 14490 ]
            simmonsja James A Simmons made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Neil Brown [ neilb ]
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40001/
            Subject: LU-13977 tests: fix float comparison in sanity test_255a
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: f3b8f3fad502354bed7c3f743e5346200f7a584e

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/40001/ Subject: LU-13977 tests: fix float comparison in sanity test_255a Project: fs/lustre-release Branch: master Current Patch Set: Commit: f3b8f3fad502354bed7c3f743e5346200f7a584e
            gerrit Gerrit Updater added a comment -

            Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/40001
            Subject: LU-13977 tests: fix float comparison in sanity test_255a
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 2033764e3fbbcc75de125121f4b57e262808d317

            gerrit Gerrit Updater added a comment - Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/40001 Subject: LU-13977 tests: fix float comparison in sanity test_255a Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2033764e3fbbcc75de125121f4b57e262808d317
            neilb Neil Brown created issue -

            People

              neilb Neil Brown
              neilb Neil Brown
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: