[LU-14543] tgt_grant_discard(): avoid tgd->tgd_tot_granted overflowing

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.12.8, Lustre 2.15.0
• Severity: 3
• Assignee: Vladimir Saveliev
• Reporter: Vladimir Saveliev

Description

void tgt_grant_discard(struct obd_export *exp)
...
        if (tgd->tgd_tot_granted < ted->ted_grant) {
                CERROR("%s: tot_granted %llu < cli %s/%p ted_grant %ld\n",
                       obd->obd_name, tgd->tgd_tot_granted,
                       exp->exp_client_uuid.uuid, exp, ted->ted_grant);
        }
        tgd->tgd_tot_granted -= ted->ted_grant;
...

If tgd->tgd_tot_granted < ted->ted_grant the decrement makes tgd_tot_granted too big.

Issue Links

• is related to: LU-15095 lctl: error invoking upcall /usr/sbin/lctl set_param *.*.lbug_on_grant_miscount=1
• is related to: LU-14125 client starved for grant but OST has plenty of free space

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/45490/
Subject: LU-14543 target: prevent overflowing of tgd->tgd_tot_granted
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 5cbc184fbc10fd3d6c23ec3b8b687ffb34a64138

[Gerrit Updater]

"Mike Pershin <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/45490
Subject: LU-14543 target: prevent overflowing of tgd->tgd_tot_granted
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 41bca5995c461c306b5269142e99e1b2695267cf

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/42129/
Subject: LU-14543 target: prevent overflowing of tgd->tgd_tot_granted
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bb5d81ea95502fb5709e176b561b70aa5280ee07

[Gerrit Updater]

Vladimir Saveliev ([e-mail]) uploaded a new patch: https://review.whamcloud.com/42129
Subject: LU-14543 target: prevent overflowing of tgd->tgd_tot_granted
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 32e970796601d0e6c1ee7ac9ced34d3a7a695be3