Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-14683

replay-single test_40: remove no longer actual test

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • Lustre 2.15.0
    • None
    • 3
    • 9223372036854775807

    Description

      test_40(){
              # always need connection to MDS to verify layout during IO. LU-2628.
              lctl get_param mdc.*.connect_flags | grep -q layout_lock &&
                      skip "layout_lock needs MDS connection for IO" && return 0
      

      should be:

              # always need connection to MDS to verify layout during IO. LU-2628.
              lctl get_param mdc.*.connect_flags | grep -q layout_lock ||
                      skip "layout_lock needs MDS connection for IO"
      

      Attachments

        Activity

          [LU-14683] replay-single test_40: remove no longer actual test
          pjones Peter Jones added a comment -

          Landed foe 2.16

          pjones Peter Jones added a comment - Landed foe 2.16

          "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/43676/
          Subject: LU-14683 tests: get rid of no longer actual test
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 5f804180fb466ae5a90875e85ddcb7064e088750

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/43676/ Subject: LU-14683 tests: get rid of no longer actual test Project: fs/lustre-release Branch: master Current Patch Set: Commit: 5f804180fb466ae5a90875e85ddcb7064e088750

          The test is no longer actual for modern Lustre with Layout lock support, as described in the following commit:

           commit 945a97dbc2f0323352950d3b54beda9f7ab799a7
          Author: Jinshan Xiong <jinshan.xiong@intel.com>
          Date:   Thu Jan 17 15:11:37 2013 -0800
          
          
              LU-2628 tests: disable test_40 of replay-single
              
              This test case assumes that IO to OSTs could go on even when the
              connect to MDT is lost, this is not true any more because clients
              have to verify the layout is correct before operating OST objects.
              
              Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
              Change-Id: I08eaad7b97da7ee152c066426f24bc1d15db5738
              Reviewed-on: http://review.whamcloud.com/5056
              Reviewed-by: Jian Yu <jian.yu@intel.com>
              Tested-by: Hudson
              Tested-by: Maloo <whamcloud.maloo@gmail.com>
              Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
          
          egryaznova Elena Gryaznova added a comment - The test is no longer actual for modern Lustre with Layout lock support, as described in the following commit: commit 945a97dbc2f0323352950d3b54beda9f7ab799a7 Author: Jinshan Xiong <jinshan.xiong@intel.com> Date: Thu Jan 17 15:11:37 2013 -0800 LU-2628 tests: disable test_40 of replay-single This test case assumes that IO to OSTs could go on even when the connect to MDT is lost, this is not true any more because clients have to verify the layout is correct before operating OST objects. Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com> Change-Id: I08eaad7b97da7ee152c066426f24bc1d15db5738 Reviewed-on: http: //review.whamcloud.com/5056 Reviewed-by: Jian Yu <jian.yu@intel.com> Tested-by: Hudson Tested-by: Maloo <whamcloud.maloo@gmail.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

          Elena Gryaznova (c17455@cray.com) uploaded a new patch: https://review.whamcloud.com/43676
          Subject: LU-14683 tests: wrong layout_lock check
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 84b5814b149cdba2526a19a14f6105ada902d5bb

          gerrit Gerrit Updater added a comment - Elena Gryaznova (c17455@cray.com) uploaded a new patch: https://review.whamcloud.com/43676 Subject: LU-14683 tests: wrong layout_lock check Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 84b5814b149cdba2526a19a14f6105ada902d5bb

          Wow, this code dates back to commit 2.3.62-6-g945a97dbc2, over 8 years ago. I see this subtest is always being skipped in autotest, so the check is clearly incorrect.

          adilger Andreas Dilger added a comment - Wow, this code dates back to commit 2.3.62-6-g945a97dbc2, over 8 years ago. I see this subtest is always being skipped in autotest, so the check is clearly incorrect.

          People

            egryaznova Elena Gryaznova
            egryaznova Elena Gryaznova
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: