[LU-14683] replay-single test_40: remove no longer actual test

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Affects Version/s: Lustre 2.15.0

Epic/Theme

patch

• Severity: 3
• Assignee: Elena Gryaznova
• Reporter: Elena Gryaznova

Description

test_40(){
        # always need connection to MDS to verify layout during IO. LU-2628.
        lctl get_param mdc.*.connect_flags | grep -q layout_lock &&
                skip "layout_lock needs MDS connection for IO" && return 0

should be:

        # always need connection to MDS to verify layout during IO. LU-2628.
        lctl get_param mdc.*.connect_flags | grep -q layout_lock ||
                skip "layout_lock needs MDS connection for IO"

Comments

[Peter Jones]

Landed foe 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/43676/
Subject: LU-14683 tests: get rid of no longer actual test
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5f804180fb466ae5a90875e85ddcb7064e088750

[Elena Gryaznova]

The test is no longer actual for modern Lustre with Layout lock support, as described in the following commit:

 commit 945a97dbc2f0323352950d3b54beda9f7ab799a7
Author: Jinshan Xiong <[e-mail]>
Date:   Thu Jan 17 15:11:37 2013 -0800


    LU-2628 tests: disable test_40 of replay-single
    
    This test case assumes that IO to OSTs could go on even when the
    connect to MDT is lost, this is not true any more because clients
    have to verify the layout is correct before operating OST objects.
    
    Signed-off-by: Jinshan Xiong <[e-mail]>
    Change-Id: I08eaad7b97da7ee152c066426f24bc1d15db5738
    Reviewed-on: http://review.whamcloud.com/5056
    Reviewed-by: Jian Yu <[e-mail]>
    Tested-by: Hudson
    Tested-by: Maloo <[e-mail]>
    Reviewed-by: Andreas Dilger <[e-mail]>

[Gerrit Updater]

Elena Gryaznova ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43676
Subject: LU-14683 tests: wrong layout_lock check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 84b5814b149cdba2526a19a14f6105ada902d5bb

[Andreas Dilger]

Wow, this code dates back to commit 2.3.62-6-g945a97dbc2, over 8 years ago. I see this subtest is always being skipped in autotest, so the check is clearly incorrect.