Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-14688

Changelog cancel improvement

Details

    • 9223372036854775807

    Description

      llog_changelog_cancel() processing changelog records one by one with llog_changelog_cancel_cb(). The callback decides should this record be deleted base on index at record and cookie from a caller. Since indexes at changelog records are incremented by one, and llog knows max number of records at plain llog, it is easy to calculate current plain llog file would be deleted completely or not. So logic could skip canceling record one by one in this case and delete plain llog file immediately. Plain llog file limited with 64k records, so improvement would help at massive purging, when caller cancels +65k records at once, or cancels all records.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-14705 ASSERTION( llog_osd_exist(loghandle) ) failed: with concurent "lfs changelog_clear"

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. LU-14699 changelog garbage collection is too lax

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-13772 mdt: changelog_deregister takes too long

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-14688] Changelog cancel improvement
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/43990/
            Subject: LU-14688 mdt: changelog purge deletes plain llog
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: 57583a7a3995ec931868ef85445059e988bff6fe

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/43990/ Subject: LU-14688 mdt: changelog purge deletes plain llog Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 57583a7a3995ec931868ef85445059e988bff6fe
            eaujames Etienne Aujames added a comment -

            I have backported the 43719 to correct the LU-14705 bug.

            eaujames Etienne Aujames added a comment - I have backported the 43719 to correct the LU-14705 bug.
            gerrit Gerrit Updater added a comment -

            Etienne AUJAMES (eaujames@ddn.com) uploaded a new patch: https://review.whamcloud.com/43990
            Subject: LU-14688 mdt: changelog purge deletes plain llog
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 468a323a906f8bdaf729cf857010cd4598d8a0a6

            gerrit Gerrit Updater added a comment - Etienne AUJAMES (eaujames@ddn.com) uploaded a new patch: https://review.whamcloud.com/43990 Subject: LU-14688 mdt: changelog purge deletes plain llog Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 468a323a906f8bdaf729cf857010cd4598d8a0a6
            pjones Peter Jones added a comment -

            Landed for 2.15

            pjones Peter Jones added a comment - Landed for 2.15
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43719/
            Subject: LU-14688 mdt: changelog purge deletes plain llog
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: d813c75df6798efbf3228347628c0d671ca7269c

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43719/ Subject: LU-14688 mdt: changelog purge deletes plain llog Project: fs/lustre-release Branch: master Current Patch Set: Commit: d813c75df6798efbf3228347628c0d671ca7269c
            gerrit Gerrit Updater added a comment -

            Alexander Boyko (alexander.boyko@hpe.com) uploaded a new patch: https://review.whamcloud.com/43719
            Subject: LU-14688 mdt: changelog purge deletes plain llog
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: ba44bdf94e24ab7237837de047f0e3d985d7ab74

            gerrit Gerrit Updater added a comment - Alexander Boyko (alexander.boyko@hpe.com) uploaded a new patch: https://review.whamcloud.com/43719 Subject: LU-14688 mdt: changelog purge deletes plain llog Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ba44bdf94e24ab7237837de047f0e3d985d7ab74

            People

              aboyko Alexander Boyko
              aboyko Alexander Boyko
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: