[LU-15614] Variable incorrectly used in sanity-flr/203

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Arshad Hussain
• Reporter: Arshad Hussain

Description

Under sanity-flr.sh/203 variable 'old_id' and
 'new_id' is defined incorrectly as 'oldid' and
 'newid'. This leads to a comparison between the
 two as always true and leading to false positive.
 This was exposed using shellcheck.
    
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In lustre/tests/sanity-flr.sh line 3258:
    [[ x$oldid = x$newid ]] ||
    ^-- SC2154: oldid is referenced but not assigned (did you mean 'old_id'?).
    ^-- SC2154: newid is referenced but not assigned (did you mean 'new_id'?).
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Issue Links

• is related to: LU-15617 Add shellcheck to prepare-commit-msg

Comments

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/46690/
Subject: LU-15614 tests: Variable incorrectly used in sanity-flr/203
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 94dee86fbcf72ded71c633f7de1bdf2713d6d769

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/46690
Subject: LU-15614 tests: Variable incorrectly used in sanity-flr/203
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b81fac3667fd4203628c5a23a5b8b4f31ef7a67b