[LU-15811] simplify lower/upper AIO/DIO code

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.2
• Severity: 3
• Assignee: Patrick Farrell
• Reporter: Patrick Farrell

Description

One of the patches for LU-13799, "Implement lower/upper aio" (https://review.whamcloud.com/44209/) created a complicated setup where the cl_dio_aio struct was used both for the top level DIO or AIO and for the lower level sub I/Os (corresponding to stripes).

This is quite complicated and hard to follow, so this rewrites these two uses to be separate structs.  This incidentally fixes at least one possible memory leak.

This is an attempt to clean up the code to make some bugs easier to identify.  This may be a prelude to moving the top level AIO to a different struct from the DIO.

Issue Links

• is related to: LU-16132 NULL pointer dereference lu_object_put