Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-16335

"lfs rm_entry" failed to remove broken directories

Details

    • 3
    • 9223372036854775807

    Description

      In LU-16159, update logs are canceled upon recovery abort, which may leave some directories broken, and can't be removed by "lfs rm_entry". This is because "lfs rm_entry" failed some sanity check, but it will leave end-user a broken filesystem without any way to fix.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16159 remove update llog files after recovery abort

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-16398 ost-pools: FAIL: remove sub-test dirs failed

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16336 LFSCK should fix inconsistencies caused by recovery abort

          • Major - Major loss of function.
          • Open

          Activity

            [LU-16335] "lfs rm_entry" failed to remove broken directories
            gerrit Gerrit Updater added a comment -

            "Etienne AUJAMES <eaujames@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51237
            Subject: LU-16335 test: add fail_abort_cleanup()
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set: 1
            Commit: 2e35cdf5abe712084351d92f2b4feb99b98da08c

            gerrit Gerrit Updater added a comment - "Etienne AUJAMES <eaujames@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51237 Subject: LU-16335 test: add fail_abort_cleanup() Project: fs/lustre-release Branch: b2_15 Current Patch Set: 1 Commit: 2e35cdf5abe712084351d92f2b4feb99b98da08c
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49776/
            Subject: LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set:
            Commit: 8a8747d319aa3f91674b156c79d44cbc092ee175

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49776/ Subject: LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h Project: fs/lustre-release Branch: b2_15 Current Patch Set: Commit: 8a8747d319aa3f91674b156c79d44cbc092ee175
            gerrit Gerrit Updater added a comment -

            "Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49776
            Subject: LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h
            Project: fs/lustre-release
            Branch: b2_15
            Current Patch Set: 1
            Commit: 11d59e1f9407f8545172b00a23a34385366b4fe6

            gerrit Gerrit Updater added a comment - "Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49776 Subject: LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h Project: fs/lustre-release Branch: b2_15 Current Patch Set: 1 Commit: 11d59e1f9407f8545172b00a23a34385366b4fe6
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49329/
            Subject: LU-16335 mdt: skip target check for rm_entry
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: ae98c5fdaaf37daeb328b7110cbcf42754752c9d

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49329/ Subject: LU-16335 mdt: skip target check for rm_entry Project: fs/lustre-release Branch: master Current Patch Set: Commit: ae98c5fdaaf37daeb328b7110cbcf42754752c9d
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49335/
            Subject: LU-16335 test: add fail_abort_cleanup()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: d5fe41a02a6ed57bcbfc4a4c695bb509c9c7c313

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49335/ Subject: LU-16335 test: add fail_abort_cleanup() Project: fs/lustre-release Branch: master Current Patch Set: Commit: d5fe41a02a6ed57bcbfc4a4c695bb509c9c7c313
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49328/
            Subject: LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: efc5c8d4de60d394344506f7cfb188eaf04a4bac

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49328/ Subject: LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h Project: fs/lustre-release Branch: master Current Patch Set: Commit: efc5c8d4de60d394344506f7cfb188eaf04a4bac
            laisiyao Lai Siyao added a comment -

            In theory lfsck should fix these inconsistencies, but it's not fully tested, and LU-16159 test result shows some are not fixed, and it will be addressed in LU-16336.

            laisiyao Lai Siyao added a comment - In theory lfsck should fix these inconsistencies, but it's not fully tested, and LU-16159 test result shows some are not fixed, and it will be addressed in LU-16336 .
            simmonsja James A Simmons added a comment -

            So we disable various test for the native client since lfs rm_dentry was removed upstream. Its considered a security risk. Does this mean lfsck can repair the file system?

            simmonsja James A Simmons added a comment - So we disable various test for the native client since lfs rm_dentry was removed upstream. Its considered a security risk. Does this mean lfsck can repair the file system?
            gerrit Gerrit Updater added a comment -

            "Lai Siyao <lai.siyao@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49335
            Subject: LU-16335 test: add fail_abort_cleanup()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 243ffa00d0a4353c78ee8b73bdce0e1c60bdc5da

            gerrit Gerrit Updater added a comment - "Lai Siyao <lai.siyao@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49335 Subject: LU-16335 test: add fail_abort_cleanup() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 243ffa00d0a4353c78ee8b73bdce0e1c60bdc5da

            People

              laisiyao Lai Siyao
              laisiyao Lai Siyao
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: