[LU-16392] Bash completion regressions, lctl and lfs

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Affects Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: Thomas Bertschinger
• Reporter: Thomas Bertschinger

Description

There are a few regressions introduced in the bash completions for lctl and lfs.

1. Attempting completion for lctl prints a message to stderr and does not generate any completions. To test this behavior interactively, type lctl <tab>. To test this behavior programmatically, run

source lustre/scripts/bash-completion/lustre; COMPLETIONS=$( _lustre_cmds lctl) && [ ! -z "$COMPLETIONS" ]

An exit status of 1 indicates the bug is present.

 

2. Completion for lfs check gives incorrect results.

 

3. Attempting completion for lfs find -component-flags erroneously prints a message to stderr.

Issue Links

• is related to: LU-9830 string truncation from snprintf in libcfs/util/parser.c::Parser_list_commands()
• is related to: LU-5170 lfs usability
• is related to: LU-8621 Parser_execarg() prints help to stderr, usage to stdout
• is related to: LU-13225 add bash completion for lfs
• is related to: LU-12734 bash completion (for now: lctl set/get_param)
• is related to: LU-930 Update or improvement to a Lustre man page, documentation, or messages